From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCHv2 5/5] evtchn: pad struct evtchn to 64 bytes
Date: Tue, 16 Jun 2015 12:59:34 +0100
Message-ID: <55802BC60200007800085766@mail.emea.novell.com>
References: <1434383299-21833-1-git-send-email-david.vrabel@citrix.com>
	<1434383299-21833-6-git-send-email-david.vrabel@citrix.com>
	<55800532.7070904@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <JBeulich@suse.com>) id 1Z4pWk-0002w0-Bl
	for xen-devel@lists.xenproject.org; Tue, 16 Jun 2015 11:59:38 +0000
In-Reply-To: <55800532.7070904@citrix.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>
Cc: xen-devel@lists.xenproject.org, Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>, David Vrabel <david.vrabel@citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

>>> On 16.06.15 at 13:14, <julien.grall@citrix.com> wrote:
> On 15/06/2015 16:48, David Vrabel wrote:
>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
>> index 44ea92d..a0ff9d2 100644
>> --- a/xen/include/xen/sched.h
>> +++ b/xen/include/xen/sched.h
>> @@ -129,7 +129,7 @@ struct evtchn
>>   #endif
>>       } ssid;
>>   #endif
>> -};
>> +} __attribute__((aligned(64)));
> 
> Why don't you use __cacheline_aligned?

That would double the size on x86, for little or no benefit.

Jan