From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCHv2 3/5] evtchn: use a per-event channel lock for sending events Date: Tue, 16 Jun 2015 16:58:34 +0100 Message-ID: <558047AA.3040600@citrix.com> References: <1434383299-21833-1-git-send-email-david.vrabel@citrix.com> <1434383299-21833-4-git-send-email-david.vrabel@citrix.com> <5580060502000078000855A9@mail.emea.novell.com> <55803E73.2010603@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z4tQU-00085h-0x for xen-devel@lists.xenproject.org; Tue, 16 Jun 2015 16:09:26 +0000 In-Reply-To: <55803E73.2010603@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel , Jan Beulich Cc: xen-devel@lists.xenproject.org, Keir Fraser , Ian Campbell , Tim Deegan List-Id: xen-devel@lists.xenproject.org On 16/06/15 16:19, David Vrabel wrote: >>> @@ -1221,6 +1277,8 @@ void notify_via_xen_event_channel(struct domain *ld, int lport) >>> evtchn_port_set_pending(rd, rchn->notify_vcpu_id, rchn); >>> } >>> >>> + spin_unlock(&lchn->lock); >>> + >>> spin_unlock(&ld->event_lock); >>> } >> >> Again I think the event lock can be dropped earlier now. > > Ditto. Uh, no. This is notify. I've kept the locking like this because of the ld->is_dying check. I think we need the ld->event_lock in case d->is_dying is set and evtchn_destroy(ld) is called. David