From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH 4/6] xen/pass-through: correctly deal with
 RW1C bits
Date: Tue, 16 Jun 2015 15:38:59 +0100
Message-ID: <558051230200007800085956__23524.8797609986$1434465593$gmane$org@mail.emea.novell.com>
References: <5571AA3B020000780008152E@mail.emea.novell.com>
	<5571AC2E020000780008156B@mail.emea.novell.com>
	<alpine.DEB.2.02.1506161512200.21829@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <JBeulich@suse.com>) id 1Z4s12-0007o3-FG
	for xen-devel@lists.xenproject.org; Tue, 16 Jun 2015 14:39:04 +0000
In-Reply-To: <alpine.DEB.2.02.1506161512200.21829@kaball.uk.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, qemu-devel@nongnu.org
List-Id: xen-devel@lists.xenproject.org

>>> On 16.06.15 at 16:19, <stefano.stabellini@eu.citrix.com> wrote:
> On Fri, 5 Jun 2015, Jan Beulich wrote:
>> @@ -1016,11 +1002,12 @@ static XenPTRegInfo xen_pt_emu_reg_pm[] 
>>          .size       = 2,
>>          .init_val   = 0x0008,
>>          .res_mask   = 0x00F0,
>> -        .ro_mask    = 0xE10C,
>> +        .ro_mask    = 0x610C,
>> +        .rw1c_mask  = 0x8000,
>>          .emu_mask   = 0x810B,
>>          .init       = xen_pt_common_reg_init,
>>          .u.w.read   = xen_pt_word_reg_read,
>> -        .u.w.write  = xen_pt_pmcsr_reg_write,
>> +        .u.w.write  = xen_pt_word_reg_write,
>>      },
>>      {
>>          .size = 0,
> 
> I can see that the code change doesn't cause a change in behaviour for
> PCI_PM_CTRL, but it does for PCI_STATUS, PCI_EXP_DEVSTA and
> PCI_EXP_LNKSTA. Please explain why in the commit message.

I'm not sure what you're after in a patch titled "correctly deal with
RW1C bits".

Jan