From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753440AbbFQJXs (ORCPT ); Wed, 17 Jun 2015 05:23:48 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:45004 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752636AbbFQJXp (ORCPT ); Wed, 17 Jun 2015 05:23:45 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-8f-55813c9f0053 Message-id: <55813C9C.1010608@samsung.com> Date: Wed, 17 Jun 2015 11:23:40 +0200 From: Beata Michalska User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Leon Romanovsky Cc: "linux-kernel@vger.kernel.org" , Linux-FSDevel , linux-api@vger.kernel.org, Greg Kroah , jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, Hugh Dickins , lczerner@redhat.com, hch@infradead.org, linux-ext4@vger.kernel.org, Linux-MM , kyungmin.park@samsung.com, kmpark@infradead.org Subject: Re: [RFC v3 4/4] shmem: Add support for generic FS events References: <1434460173-18427-1-git-send-email-b.michalska@samsung.com> <1434460173-18427-5-git-send-email-b.michalska@samsung.com> In-reply-to: Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPIsWRmVeSWpSXmKPExsVy+t/xq7rzbRpDDa7vEbD4+qWDxeLcghmM FqcnLGKyePqpj8Vi9vRmJotbl1exWJxtesNusezBZhaLQ9P/sFps/t7BZjFz3h02iz17T7JY XN41h83i3pr/rBatPT/ZHfg9WjaXeyzYVOqxeYWWx9uHAR6bPk1i9+iZnu3RdOYos8f7fVfZ PPq2rGL0OLPgCLvH501yAdxRXDYpqTmZZalF+nYJXBmzv6xiKnjLUrF7/hK2Bsb7TF2MnBwS AiYSD9fcZoewxSQu3FvP1sXIxSEksJRR4sn95ewQzjNGiYe7uthAqngFtCTOtMxhBrFZBFQl FmydDBZnE9CXeDVjJdhUUYEIiT+n97FC1AtK/Jh8jwXEFhFQkpj8dS/YUGaBecwSz660gq0W FnCS+PnyBAvEtjOMElsOt4F1cAoES7y7/Q1sG7OAusSkeYugbHmJzWveMk9gFJiFZMksJGWz kJQtYGRexSiaWppcUJyUnmuoV5yYW1yal66XnJ+7iRESbV92MC4+ZnWIUYCDUYmHt2FHQ6gQ a2JZcWXuIUYJDmYlEV49zcZQId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rxzd70PERJITyxJzU5N LUgtgskycXBKNTDKrBS9MdNTwHDOssR9E/ounZ/stHi/Vsrfc7fr500/9e/85rls1lwzynbN 2rz3mJWea/LJJ0pnqnr+/Hy8qbl/72st53D1LTWNnR6O2eJtGg9PJyV/XSYpreQv3zqjpKL+ xtd1C+IDHupUTQvQdjwQsZ+30j7guJpx4QYx5Us7LgnMM7R/uSpBiaU4I9FQi7moOBEANR65 w7ICAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2015 08:08 AM, Leon Romanovsky wrote: >> } >> - if (error == -ENOSPC && !once++) { >> + if (error == -ENOSPC) { >> + if (!once++) { >> info = SHMEM_I(inode); >> spin_lock(&info->lock); >> shmem_recalc_inode(inode); >> spin_unlock(&info->lock); >> goto repeat; >> + } else { >> + fs_event_notify(inode->i_sb, FS_WARN_ENOSPC); >> + } >> } > > Very minor remark, please fix indentation. > I will, thank You. BR Beata From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by kanga.kvack.org (Postfix) with ESMTP id F2E4B6B007B for ; Wed, 17 Jun 2015 05:23:48 -0400 (EDT) Received: by pacgb13 with SMTP id gb13so31564354pac.1 for ; Wed, 17 Jun 2015 02:23:48 -0700 (PDT) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com. [210.118.77.12]) by mx.google.com with ESMTPS id ha1si5330561pbd.249.2015.06.17.02.23.47 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 17 Jun 2015 02:23:48 -0700 (PDT) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NQ300I870RJ7R00@mailout2.w1.samsung.com> for linux-mm@kvack.org; Wed, 17 Jun 2015 10:23:43 +0100 (BST) Message-id: <55813C9C.1010608@samsung.com> Date: Wed, 17 Jun 2015 11:23:40 +0200 From: Beata Michalska MIME-version: 1.0 Subject: Re: [RFC v3 4/4] shmem: Add support for generic FS events References: <1434460173-18427-1-git-send-email-b.michalska@samsung.com> <1434460173-18427-5-git-send-email-b.michalska@samsung.com> In-reply-to: Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Leon Romanovsky Cc: "linux-kernel@vger.kernel.org" , Linux-FSDevel , linux-api@vger.kernel.org, Greg Kroah , jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, Hugh Dickins , lczerner@redhat.com, hch@infradead.org, linux-ext4@vger.kernel.org, Linux-MM , kyungmin.park@samsung.com, kmpark@infradead.org On 06/17/2015 08:08 AM, Leon Romanovsky wrote: >> } >> - if (error == -ENOSPC && !once++) { >> + if (error == -ENOSPC) { >> + if (!once++) { >> info = SHMEM_I(inode); >> spin_lock(&info->lock); >> shmem_recalc_inode(inode); >> spin_unlock(&info->lock); >> goto repeat; >> + } else { >> + fs_event_notify(inode->i_sb, FS_WARN_ENOSPC); >> + } >> } > > Very minor remark, please fix indentation. > I will, thank You. BR Beata -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org