From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 16/27] tools/libxl: Infrastructure for
 reading a libxl migration v2 stream
Date: Wed, 17 Jun 2015 10:47:00 +0100
Message-ID: <55814214.6050909@citrix.com>
References: <1434375880-30914-1-git-send-email-andrew.cooper3@citrix.com>
	<1434375880-30914-17-git-send-email-andrew.cooper3@citrix.com>
	<55810DCC.8020608@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55810DCC.8020608@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wen Congyang <wency@cn.fujitsu.com>, Xen-devel <xen-devel@lists.xen.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Ross Lagerwall <ross.lagerwall@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 17/06/15 07:03, Wen Congyang wrote:
>> +static void stream_failed(libxl__egc *egc,
>> > +                          libxl__stream_read_state *stream, int rc)
>> > +{
>> > +    assert(rc);
>> > +    stream->rc = rc;
> I have a question: rc is always less than 0?
>
> Thanks
> Wen Congyang
>

I believe so.  It should realistically always be an ERROR_$foo

~Andrew