From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 20/27] tools/libxl: Infrastructure for
	writing a v2 stream
Date: Wed, 17 Jun 2015 10:51:20 +0100
Message-ID: <55814318.5060007@citrix.com>
References: <1434375880-30914-1-git-send-email-andrew.cooper3@citrix.com>
	<1434375880-30914-21-git-send-email-andrew.cooper3@citrix.com>
	<5580CDE9.7030800@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5580CDE9.7030800@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Yang Hongyang <yanghy@cn.fujitsu.com>, Xen-devel <xen-devel@lists.xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Ross Lagerwall <ross.lagerwall@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 17/06/15 02:31, Yang Hongyang wrote:
>> +    default:
>> +        ret = ERROR_FAIL;
>> +        goto err;
>> +    }
>> +
>> +    ret = libxl__domain_suspend_device_model(gc, dss);
>
> This is no longer needed, the suspend callback already called
> this function and the emulator context already saved to a file.
>
> This call will cause Primary's emulator stop under Remus.
> postcopy callback will resume primary. then in checkpoint
> callback, we shouldn't suspend device model. 

It is the result of copying how everything was done previously.  I will
drop it.

~Andrew