From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Dt2-00053Z-2u for qemu-devel@nongnu.org; Wed, 17 Jun 2015 10:00:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5Dsx-0007Wl-2x for qemu-devel@nongnu.org; Wed, 17 Jun 2015 10:00:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Dsw-0007Wh-U8 for qemu-devel@nongnu.org; Wed, 17 Jun 2015 10:00:11 -0400 Message-ID: <55817D66.2090303@redhat.com> Date: Wed, 17 Jun 2015 16:00:06 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20150612140845.GD2749@TopQuark.net> In-Reply-To: <20150612140845.GD2749@TopQuark.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-timer: Call clock reset notifiers on forward jumps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Donohue , qemu-devel@nongnu.org On 12/06/2015 16:08, Paul Donohue wrote: > +static inline int64_t get_max_clock_jump(void) > +{ > + // This should be small enough to prevent excessive interrupts from being > + // generated by the RTC on clock jumps, but large enough to avoid frequent > + // unnecessary resets in idle VMs. This is not how comments are layed out in QEMU... > + return 60 * get_ticks_per_sec(); > +} > + > /* > * * Low level clock functions > * */ ... and it also looks like your editor has mangled this patch. Nevertheless, I've applied it to my local branch and will send it out for inclusion after some more testing. Paolo > diff --git a/qemu-timer.c b/qemu-timer.c > index 5741f0d..d27be3d 100644 > --- a/qemu-timer.c > +++ b/qemu-timer.c