From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH v2 02/17] x86/hvm: re-name struct
 hvm_mmio_handler to hvm_mmio_ops
Date: Wed, 17 Jun 2015 13:43:46 +0100
Message-ID: <558187A202000078000861ED@mail.emea.novell.com>
References: <1434037381-10917-1-git-send-email-paul.durrant@citrix.com>
	<1434037381-10917-3-git-send-email-paul.durrant@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <JBeulich@suse.com>) id 1Z5Ch4-0008Je-M4
	for xen-devel@lists.xenproject.org; Wed, 17 Jun 2015 12:43:50 +0000
In-Reply-To: <1434037381-10917-3-git-send-email-paul.durrant@citrix.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Paul Durrant <paul.durrant@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Keir Fraser <keir@xen.org>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

>>> On 11.06.15 at 17:42, <paul.durrant@citrix.com> wrote:
> The struct just contains three methods and no data, so the name
> hvm_mmio_ops more accurately reflects its content. A subsequent patch
> introduces a new structure which more accurately warrants the name
> hvm_mmio_handler so doing the rename in this purely cosmetic patch avoids
> conflating functional and cosmetic changes in a single patch.
> 
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>
albeit

> @@ -182,21 +182,21 @@ int hvm_mmio_intercept(ioreq_t *p)
>  
>      for ( i = 0; i < HVM_MMIO_HANDLER_NR; i++ )
>      {
> -        hvm_mmio_check_t check_handler =
> -            hvm_mmio_handlers[i]->check_handler;
> +        hvm_mmio_check_t check =
> +            hvm_mmio_handlers[i]->check;

Does this still not fit on a single line?

Jan