From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH v2 1/3] net: mvneta: introduce compatible string "marvell, armada-xp-neta" Date: Wed, 17 Jun 2015 17:15:28 +0200 Message-ID: <55818F10.8030304@free-electrons.com> References: <1434547162-6275-1-git-send-email-simon.guinot@sequanux.org> <1434547162-6275-2-git-send-email-simon.guinot@sequanux.org> <55818E64.20007@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Thomas Petazzoni , Andrew Lunn , Jason Cooper , netdev@vger.kernel.org, Vincent Donnefort , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth To: Simon Guinot Return-path: Received: from down.free-electrons.com ([37.187.137.238]:36364 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756552AbbFQPPb (ORCPT ); Wed, 17 Jun 2015 11:15:31 -0400 In-Reply-To: <55818E64.20007@free-electrons.com> Sender: netdev-owner@vger.kernel.org List-ID: On 17/06/2015 17:12, Gregory CLEMENT wrote: > Hi Simon, > > On 17/06/2015 15:19, Simon Guinot wrote: >> The mvneta driver supports the Ethernet IP found in the Armada 370, XP, >> 380 and 385 SoCs. Since at least one more hardware feature is available >> for the Armada XP SoCs then a way to identify them is needed. >> >> This patch introduces a new compatible string "marvell,armada-xp-neta". > > Let's be future proof by going further. I would like to have an compatible string > for each SoC even if we currently we don't use them. > > You even don't have to use add it in the mvneta.c file if you use: > "marvell,armada-380-neta", "marvell,armada-xp-neta" Actually I meant: "marvell,armada-380-neta", "marvell,armada-370-neta" > > > Thanks, > > Gregory > > >> Signed-off-by: Simon Guinot >> Cc: # v3.8+ >> --- >> Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt | 2 +- >> drivers/net/ethernet/marvell/mvneta.c | 1 + >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt b/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt >> index 750d577e8083..f5a8ca29aff0 100644 >> --- a/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt >> +++ b/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt >> @@ -1,7 +1,7 @@ >> * Marvell Armada 370 / Armada XP Ethernet Controller (NETA) >> >> Required properties: >> -- compatible: should be "marvell,armada-370-neta". >> +- compatible: "marvell,armada-370-neta" or "marvell,armada-xp-neta". >> - reg: address and length of the register set for the device. >> - interrupts: interrupt for the device >> - phy: See ethernet.txt file in the same directory. >> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c >> index ce5f7f9cff06..aceb977b104d 100644 >> --- a/drivers/net/ethernet/marvell/mvneta.c >> +++ b/drivers/net/ethernet/marvell/mvneta.c >> @@ -3179,6 +3179,7 @@ static int mvneta_remove(struct platform_device *pdev) >> >> static const struct of_device_id mvneta_match[] = { >> { .compatible = "marvell,armada-370-neta" }, >> + { .compatible = "marvell,armada-xp-neta" }, >> { } >> }; >> MODULE_DEVICE_TABLE(of, mvneta_match); >> > > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Wed, 17 Jun 2015 17:15:28 +0200 Subject: [PATCH v2 1/3] net: mvneta: introduce compatible string "marvell, armada-xp-neta" In-Reply-To: <55818E64.20007@free-electrons.com> References: <1434547162-6275-1-git-send-email-simon.guinot@sequanux.org> <1434547162-6275-2-git-send-email-simon.guinot@sequanux.org> <55818E64.20007@free-electrons.com> Message-ID: <55818F10.8030304@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 17/06/2015 17:12, Gregory CLEMENT wrote: > Hi Simon, > > On 17/06/2015 15:19, Simon Guinot wrote: >> The mvneta driver supports the Ethernet IP found in the Armada 370, XP, >> 380 and 385 SoCs. Since at least one more hardware feature is available >> for the Armada XP SoCs then a way to identify them is needed. >> >> This patch introduces a new compatible string "marvell,armada-xp-neta". > > Let's be future proof by going further. I would like to have an compatible string > for each SoC even if we currently we don't use them. > > You even don't have to use add it in the mvneta.c file if you use: > "marvell,armada-380-neta", "marvell,armada-xp-neta" Actually I meant: "marvell,armada-380-neta", "marvell,armada-370-neta" > > > Thanks, > > Gregory > > >> Signed-off-by: Simon Guinot >> Cc: # v3.8+ >> --- >> Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt | 2 +- >> drivers/net/ethernet/marvell/mvneta.c | 1 + >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt b/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt >> index 750d577e8083..f5a8ca29aff0 100644 >> --- a/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt >> +++ b/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt >> @@ -1,7 +1,7 @@ >> * Marvell Armada 370 / Armada XP Ethernet Controller (NETA) >> >> Required properties: >> -- compatible: should be "marvell,armada-370-neta". >> +- compatible: "marvell,armada-370-neta" or "marvell,armada-xp-neta". >> - reg: address and length of the register set for the device. >> - interrupts: interrupt for the device >> - phy: See ethernet.txt file in the same directory. >> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c >> index ce5f7f9cff06..aceb977b104d 100644 >> --- a/drivers/net/ethernet/marvell/mvneta.c >> +++ b/drivers/net/ethernet/marvell/mvneta.c >> @@ -3179,6 +3179,7 @@ static int mvneta_remove(struct platform_device *pdev) >> >> static const struct of_device_id mvneta_match[] = { >> { .compatible = "marvell,armada-370-neta" }, >> + { .compatible = "marvell,armada-xp-neta" }, >> { } >> }; >> MODULE_DEVICE_TABLE(of, mvneta_match); >> > > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com