From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5FZ8-0007Xt-Be for qemu-devel@nongnu.org; Wed, 17 Jun 2015 11:47:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5FZ4-0003Xl-Bz for qemu-devel@nongnu.org; Wed, 17 Jun 2015 11:47:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5FZ4-0003XX-5o for qemu-devel@nongnu.org; Wed, 17 Jun 2015 11:47:46 -0400 Message-ID: <558196A0.9070208@redhat.com> Date: Wed, 17 Jun 2015 09:47:44 -0600 From: Eric Blake MIME-Version: 1.0 References: <88a1cc0775d3d4f5262b31b9452f8acccc6bbb41.1434458391.git.DirtY.iCE.hu@gmail.com> <87oakeg4eo.fsf@blackfin.pond.sub.org> <1434530501.5549.23.camel@redhat.com> <5581537F.3040005@gmail.com> In-Reply-To: <5581537F.3040005@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UKsxMNlU0SMCg2qaxr8i9DWJbd064iigV" Subject: Re: [Qemu-devel] [PATCH v2 2/6] qapi: support nested structs in OptsVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?S8WRdsOhZ8OzIFpvbHTDoW4=?= , Gerd Hoffmann , Markus Armbruster Cc: =?UTF-8?B?TMOhc3psw7MgRXJzZWs=?= , qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UKsxMNlU0SMCg2qaxr8i9DWJbd064iigV Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/17/2015 05:01 AM, K=C5=91v=C3=A1g=C3=B3 Zolt=C3=A1n wrote: >>> Can you explain why the complexity is needed, i.e. why we can't just >>> require full paths always? >> >> Keeping the short names is required for -netdev backward compatibility= =2E >> >> Restricting to short or full (i.e. something=3D or foo.bar.something=3D= , but >> disallow bar.something=3D) should not be a problem. I'm not sure this= >> simplifies things much though. We have to build the full path anyway,= >> and I think bar.something=3D is just a convenient thing we get almost = for >> free ... >=20 > With the current implementation you can specify (see my previous patch)= > in.try-poll=3Doff in case of alsa. If we would need full paths, it woul= d > look like opts.data.in.try-poll=3Doff, which is probably not something = we > want. Elsewhere in the thread, it was suggested that you use a flat union. That would simplify the full path to opts.in.try-poll, rather than opts.data.in.try-poll. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UKsxMNlU0SMCg2qaxr8i9DWJbd064iigV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVgZagAAoJEKeha0olJ0Nqb+YIAJH01cZ/WCmAxuNBN9zrMoNj HuWfweEnInVgju8+x+42/+Qgtb9tHfKIGUE5MHtd6wdyIMzKiHvGvNRe7SD1X9Ru f9Td7hj7qXJfj7Xl2h5qRWDHCg5+Ocfy1Mw3H9SVC/TKif79E+ShT+HPRydDXohq qJhFGkdNCiOaphXiop8NASwtkSVaP1FCzmjrMh5OaPY3fyPAXePlv7p3jF/osbTL 5gwsJH8rNRAqIMKwJHT/s0nBGttVEImxEFkcN7zo+r8tgAlnvNkWX+yv/ylwxSyU y1DrBf7CAoFeb2uWCmqcuZhx2kjeBQxkzsZVvoQ3GaPeO0patLXrD7IcqMlTrSE= =WxPF -----END PGP SIGNATURE----- --UKsxMNlU0SMCg2qaxr8i9DWJbd064iigV--