From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5FcB-0000eE-H4 for qemu-devel@nongnu.org; Wed, 17 Jun 2015 11:51:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5Fc7-00071C-Hf for qemu-devel@nongnu.org; Wed, 17 Jun 2015 11:50:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Fc6-000703-Ix for qemu-devel@nongnu.org; Wed, 17 Jun 2015 11:50:54 -0400 Message-ID: <5581975D.4020104@redhat.com> Date: Wed, 17 Jun 2015 09:50:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <87si9qg4kt.fsf@blackfin.pond.sub.org> <558151FC.9000703@gmail.com> <87zj3y7dyk.fsf@blackfin.pond.sub.org> In-Reply-To: <87zj3y7dyk.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rh13nf0f98W7gIukehCCmVGOSC0bOCfDb" Subject: Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , =?UTF-8?B?S8WRdsOhZ8OzIFpvbHTDoQ==?= =?UTF-8?B?bg==?= Cc: qemu-devel@nongnu.org, Michael Roth , Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rh13nf0f98W7gIukehCCmVGOSC0bOCfDb Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/17/2015 05:48 AM, Markus Armbruster wrote: > "K=C5=91v=C3=A1g=C3=B3 Zolt=C3=A1n" writes: >=20 >> 2015-06-17 09:46 keltez=C3=A9ssel, Markus Armbruster =C3=ADrta: >>> Copying Eric for additional QAPI schema expertise. >>> >>>> +{ 'struct': 'Audiodev', >>>> + 'data': { >>>> + '*id': 'str', >>>> + 'in': 'AudiodevPerDirectionOptions', >>>> + 'out': 'AudiodevPerDirectionOptions', >>>> + '*timer-period': 'int', >>>> + 'opts': 'AudiodevBackendOptions' } } >>> >>> Have you considered making this a flat union, similar ro >>> BlockdevOptions? >> >> Not really. If you qapi masters out there think it's better, then I >> will convert it. >=20 > Related: discussion about flattening in review of PATCH 2. Indeed - I think a flat union makes for nicer command line structure, and fewer {} nesting in QMP structure. I still need to spend time on the overall thread, but wanted to chime in on this comment up front. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --rh13nf0f98W7gIukehCCmVGOSC0bOCfDb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVgZddAAoJEKeha0olJ0NqJl4H/RwuM5LkOq9olFP3qVQlML/w 0qdBNbuOWayiSWwUvkwckSMUrQRPRMXbkkd8HKfZYbbHmRddc+6Fbtb2KoELeV52 vkRxyjk+VXXOIUIRJJLG3dc9jWWy0tik+HpW/37qSgNV/7nfXZ+ttqaMRasTX5V1 oDXdZTPaqI2Q5p3gKLgDJjrct5q+yFwYAyV0rIa1zMHfx6Y3vlmSv7I8JlJUCZT6 i+86D7UvXfoiTW9o34cYbhWfbwo+OwSRVzz5Wfgiemge9YitEhFHgxCyAt9YVdAT znz1LfpO8QdoQqzPD9lDTNGonxOLUEshLaQ4QVPUEAOqeasVwBE7JHJpIHCqUVQ= =F4l+ -----END PGP SIGNATURE----- --rh13nf0f98W7gIukehCCmVGOSC0bOCfDb--