From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46180)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z5G1p-0003GD-I3
	for qemu-devel@nongnu.org; Wed, 17 Jun 2015 12:17:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z5G1l-0006Br-Vp
	for qemu-devel@nongnu.org; Wed, 17 Jun 2015 12:17:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42396)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z5G1l-0006Ar-R9
	for qemu-devel@nongnu.org; Wed, 17 Jun 2015 12:17:25 -0400
Message-ID: <55819D8F.3000003@redhat.com>
Date: Wed, 17 Jun 2015 18:17:19 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1434117956-4929-1-git-send-email-dslutz@verizon.com>
	<20150617160826-mutt-send-email-mst@redhat.com>
	<558180A0.8040708@redhat.com>
	<20150617161716-mutt-send-email-mst@redhat.com>
	<558183C1.3010402@redhat.com>
	<20150617162836-mutt-send-email-mst@redhat.com>
In-Reply-To: <20150617162836-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's
	hyper-call rpc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Don Slutz <dslutz@verizon.com>, Luiz Capitulino <lcapitulino@redhat.com>, Anthony Liguori <aliguori@amazon.com>, =?windows-1252?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>



On 17/06/2015 16:29, Michael S. Tsirkin wrote:
> On Wed, Jun 17, 2015 at 04:27:13PM +0200, Paolo Bonzini wrote:
>>
>>
>> On 17/06/2015 16:18, Michael S. Tsirkin wrote:
>>>>> Yes, that's what was done for parallel and pcspk as well.  There's no
>>>>> infrastructure to avoid it.
>>>>>
>>>>> Paolo
>>> How do you mean? We have multiple ways to keep devices
>>> compatible with old versions.
>>> Set a new property to skip the extra stuff.
>>
>> Not if the device didn't have a vmstate at all, unfortunately.
> 
> Skip creating the device completely for old machine types.

Which device?  The vmstate is tied to the same device that has always
been created.
 we enable this thing by default (why do we?)
>>> this seems like a big deal ...
>>
>> The PC speaker device is also enabled by default.
> 
> This is historical, isn't it?

Yes, but it has broken 2.3->2.2 migration.

Let's just stop fighting windmills.

Paolo