From: "Kővágó Zoltán" <dirty.ice.hu@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends
Date: Thu, 18 Jun 2015 02:21:34 +0200 [thread overview]
Message-ID: <55820F0E.4050203@gmail.com> (raw)
In-Reply-To: <87h9q6720y.fsf@blackfin.pond.sub.org>
2015-06-17 18:06 keltezéssel, Markus Armbruster írta:
> "Kővágó Zoltán" <dirty.ice.hu@gmail.com> writes:
>
>> 2015-06-17 15:37 keltezéssel, Markus Armbruster írta:
>>> "Kővágó Zoltán" <dirty.ice.hu@gmail.com> writes:
>>>
>>>> 2015-06-17 13:48 keltezéssel, Markus Armbruster írta:
>>>>> "Kővágó Zoltán" <dirty.ice.hu@gmail.com> writes:
>>>>>
>>>>>> 2015-06-17 09:46 keltezéssel, Markus Armbruster írta:
> [...]
>>>>>>>> +##
>>>>>>>> +# @AudiodevBackendOptions
>>>>>>>> +#
>>>>>>>> +# A discriminated record of audio backends.
>>>>>>>> +#
>>>>>>>> +# Since: 2.4
>>>>>>>> +##
>>>>>>>> +{ 'union': 'AudiodevBackendOptions',
>>>>>>>> + 'data': {
>>>>>>>> + 'none': 'AudiodevNoOptions',
>>>>>>>> + 'alsa': 'AudiodevAlsaOptions',
>>>>>>>> + 'coreaudio': 'AudiodevNoOptions',
>>>>>>>> + 'dsound': 'AudiodevDsoundOptions',
>>>>>>>> + 'oss': 'AudiodevOssOptions',
>>>>>>>> + 'pa': 'AudiodevPaOptions',
>>>>>>>> + 'sdl': 'AudiodevNoOptions',
>>>>>>>> + 'spice': 'AudiodevNoOptions',
>>>>>>>> + 'wav': 'AudiodevWavOptions' } }
>>>>>>>> +
>>>>>>>> +##
>>>>>>>> +# @AudioFormat
>>>>>>>> +#
>>>>>>>> +# An enumeration of possible audio formats.
>>>>>>>> +#
>>>>>>>> +# Since: 2.4
>>>>>>>> +##
>>>>>>>> +{ 'enum': 'AudioFormat',
>>>>>>>> + 'data': [ 'u8', 's8', 'u16', 's16', 'u32', 's32' ] }
>>>>>>>> +
>>>>>>>> +##
>>>>>>>> +# @AudiodevPerDirectionOptions
>>>>>>>> +#
>>>>>>>> +# General audio backend options that are used for both playback
>>>>>>>> and recording.
>>>>>>>> +#
>>>>>>>> +# @fixed-settings: #optional use fixed settings for host DAC/ADC
>>>>>>>> +#
>>>>>>>> +# @frequency: #optional frequency to use when using fixed settings
>>>>>>>> +#
>>>>>>>> +# @channels: #optional number of channels when using fixed settings
>>>>>>>> +#
>>>>>>>> +# @format: #optional sample format to use when using fixed settings
>>>>>>>
>>>>>>> Are these guys used when @fixed-settings is off?
>>>>>>
>>>>>> No.
>>>>>
>>>>> If @fixed-settings, are the other three all required? If not, what are
>>>>> their defaults?
>>>>
>>>> No, they all have defaults: 44100 Hz, 2 channels and s16 format.
>>>
>>> Okay, this sort of explains why you have @fixed-settings.
>>>
>>> My first thought was that @fixed-settings is redundant, because we can
>>> have any of @frequency, @channels, @format imply fixed settings. Except
>>> that doesn't let you ask for the *default* fixed settings, as you have
>>> to specify at least one.
>>>
>>> What's the default for @fixed-settings?
>>
>> It's on by default.
>>
>>> What if I specify frequency, channels or format together with explicit
>>> fixed-settings: false?
>>
>> They will be ignored.
>>
>> The audio system currently work like this: when an audio frontend
>> wants to open an output with some format (frequency, channels, format)
>> it checks fixed-settings. If it's false, it will just open the stream
>> with the frontend specified settings. If it's true, it'll convert it
>> into the format specified by @frequency, @channels, @format, then pass
>> this converted/recoded stream to the backend.
>
> So user typically specifies either fixed-settings=off, or any
> combination of the other three (including none of them). Correct?
>
> We could reject the non-sensical combination of fixed-settings=off plus
> any of the other three instead of silently ignoring their values.
> Matter of taste, your choice.
>
> Whatever you do, make sure to document how these four work together.
>
> Thank you for educating me so patiently.
The audio backend currently works like that you can pass any
non-sensical values to it, like negative frequency, or 'kdp' count of
channels, it will silently fallback to some default value, or just fail,
but qemu will continue to run. We can make the new config more strict
(and we should, I think), so if you have any idea where should we be
more strict (without creating a backward compatibility headache), don't
hesitate to point it out.
next prev parent reply other threads:[~2015-06-18 0:21 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 12:49 [Qemu-devel] [PATCH v2 0/6] -audiodev option Kővágó, Zoltán
2015-06-16 12:49 ` [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends Kővágó, Zoltán
2015-06-17 7:46 ` Markus Armbruster
2015-06-17 10:54 ` Kővágó Zoltán
2015-06-17 11:48 ` Markus Armbruster
2015-06-17 12:07 ` Kővágó Zoltán
2015-06-17 13:37 ` Markus Armbruster
2015-06-17 13:53 ` Kővágó Zoltán
2015-06-17 16:06 ` Markus Armbruster
2015-06-18 0:21 ` Kővágó Zoltán [this message]
2015-06-18 8:51 ` Markus Armbruster
2015-06-17 15:50 ` Eric Blake
2015-06-16 12:49 ` [Qemu-devel] [PATCH v2 2/6] qapi: support nested structs in OptsVisitor Kővágó, Zoltán
2015-06-17 7:50 ` Markus Armbruster
2015-06-17 8:41 ` Gerd Hoffmann
2015-06-17 11:01 ` Kővágó Zoltán
2015-06-17 11:50 ` Markus Armbruster
2015-06-17 15:47 ` Eric Blake
2015-06-17 11:18 ` Markus Armbruster
2015-06-17 12:11 ` Kővágó Zoltán
2015-06-17 13:41 ` Markus Armbruster
2015-06-17 14:02 ` Kővágó Zoltán
2015-06-17 16:10 ` Markus Armbruster
2015-06-16 12:49 ` [Qemu-devel] [PATCH v2 3/6] opts: do not print separator before first item in qemu_opts_print Kővágó, Zoltán
2015-06-17 7:53 ` Markus Armbruster
2015-06-17 9:02 ` Kevin Wolf
2015-06-16 12:49 ` [Qemu-devel] [PATCH v2 4/6] qapi: AllocVisitor Kővágó, Zoltán
2015-06-17 7:56 ` Markus Armbruster
2015-06-17 12:01 ` Kővágó Zoltán
2015-06-17 13:42 ` Markus Armbruster
2015-06-16 12:49 ` [Qemu-devel] [PATCH v2 5/6] audio: use qapi AudioFormat instead of audfmt_e Kővágó, Zoltán
2015-06-17 8:01 ` Markus Armbruster
2015-06-17 11:05 ` Kővágó Zoltán
2015-06-17 11:51 ` Markus Armbruster
2015-06-17 16:01 ` Eric Blake
2015-06-16 12:49 ` [Qemu-devel] [PATCH v2 6/6] audio: -audiodev command line option Kővágó, Zoltán
2015-06-17 8:13 ` Markus Armbruster
2015-06-17 11:18 ` Kővágó Zoltán
2015-06-17 12:27 ` Markus Armbruster
2015-06-17 13:25 ` Kővágó Zoltán
2015-06-17 16:13 ` Markus Armbruster
2015-06-18 6:54 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55820F0E.4050203@gmail.com \
--to=dirty.ice.hu@gmail.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.