From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750973AbbFRC1I (ORCPT ); Wed, 17 Jun 2015 22:27:08 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:50344 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800AbbFRC07 (ORCPT ); Wed, 17 Jun 2015 22:26:59 -0400 Message-ID: <55822C71.2040409@wwwdotorg.org> Date: Wed, 17 Jun 2015 20:26:57 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?Tm9yYWxmIFRyw7hubmVz?= CC: tglx@linutronix.de, jason@lakedaemon.net, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] irqchip: bcm2835: Add FIQ support References: <1434130016-26574-1-git-send-email-noralf@tronnes.org> In-Reply-To: <1434130016-26574-1-git-send-email-noralf@tronnes.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/12/2015 11:26 AM, Noralf Trønnes wrote: > Add a duplicate irq range with an offset on the hwirq's so the > driver can detect that enable_fiq() is used. > Tested with downstream dwc_otg USB controller driver. This basically looks OK, but a few comments/thoughts: a) Should the Kconfig change be a separate patch since it's a separate subsystem? b) Doesn't the driver need to refuse some operation (handler registration, IRQ setup, IRQ enable, ...?) for more than 1 IRQ in the FIQ range, since the FIQ control register only allows routing 1 IRQ to FIQ. c) The DT binding needs updating to describe the extra IRQs: > Documentation/devicetree/bindings/interrupt-controller/brcm,bcm28armctrl-ic.txt d) I wonder how the FIQ handler actually gets routed to this controller and hooked to its handler etc. I assume there's a separate patch for that coming? BTW, I'll be on vacation for just over a couple weeks starting Saturday, so responses will certainly be delayed for a quite a while. From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Wed, 17 Jun 2015 20:26:57 -0600 Subject: [PATCH] irqchip: bcm2835: Add FIQ support In-Reply-To: <1434130016-26574-1-git-send-email-noralf@tronnes.org> References: <1434130016-26574-1-git-send-email-noralf@tronnes.org> Message-ID: <55822C71.2040409@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/12/2015 11:26 AM, Noralf Tr?nnes wrote: > Add a duplicate irq range with an offset on the hwirq's so the > driver can detect that enable_fiq() is used. > Tested with downstream dwc_otg USB controller driver. This basically looks OK, but a few comments/thoughts: a) Should the Kconfig change be a separate patch since it's a separate subsystem? b) Doesn't the driver need to refuse some operation (handler registration, IRQ setup, IRQ enable, ...?) for more than 1 IRQ in the FIQ range, since the FIQ control register only allows routing 1 IRQ to FIQ. c) The DT binding needs updating to describe the extra IRQs: > Documentation/devicetree/bindings/interrupt-controller/brcm,bcm28armctrl-ic.txt d) I wonder how the FIQ handler actually gets routed to this controller and hooked to its handler etc. I assume there's a separate patch for that coming? BTW, I'll be on vacation for just over a couple weeks starting Saturday, so responses will certainly be delayed for a quite a while.