From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5V0D-0006AL-Cz for qemu-devel@nongnu.org; Thu, 18 Jun 2015 04:16:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5V08-0005x1-AU for qemu-devel@nongnu.org; Thu, 18 Jun 2015 04:16:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5V08-0005v9-5u for qemu-devel@nongnu.org; Thu, 18 Jun 2015 04:16:44 -0400 Message-ID: <55827E67.90803@redhat.com> Date: Thu, 18 Jun 2015 10:16:39 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20150617124158.3316.54954.stgit@PASHA-ISP> <20150617124205.3316.81361.stgit@PASHA-ISP> <55816DAE.8090701@redhat.com> <000901d0a986$139ca850$3ad5f8f0$@Dovgaluk@ispras.ru> In-Reply-To: <000901d0a986$139ca850$3ad5f8f0$@Dovgaluk@ispras.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk , qemu-devel@nongnu.org Cc: rth7680@gmail.com, leon.alrae@imgtec.com, aurelien@aurel32.net On 18/06/2015 07:17, Pavel Dovgaluk wrote: >>> > > >>> > > static inline RES_TYPE >>> > > -glue(glue(cpu_ld, USUFFIX), MEMSUFFIX)(CPUArchState *env, target_ulong ptr) >>> > > +glue(glue(glue(cpu_ld, USUFFIX), MEMSUFFIX), _ra)(CPUArchState *env, >>> > > + target_ulong ptr, >>> > > + uintptr_t retaddr) >> > >> > Would it make sense to call these helper_cpu_ld##USUFFIX##MEMSUFFIX? > I don't want to use 'helper' prefix, because helper functions are > usually called directly from TB. True, but in the end these have the same functionality as helpers, just they're indirectly called from other helpers. Paolo