From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v2 05/17] x86/hvm: unify stdvga mmio intercept with standard mmio intercept Date: Thu, 18 Jun 2015 07:23:15 +0100 Message-ID: <55827FF3020000780008665B@mail.emea.novell.com> References: <1434037381-10917-1-git-send-email-paul.durrant@citrix.com> <1434037381-10917-6-git-send-email-paul.durrant@citrix.com> <5581B38202000078000864B3@mail.emea.novell.com> <9AAE0902D5BC7E449B7C8E4E778ABCD025953A73@AMSPEX01CL01.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z5TEK-0000zX-UT for xen-devel@lists.xenproject.org; Thu, 18 Jun 2015 06:23:17 +0000 In-Reply-To: <9AAE0902D5BC7E449B7C8E4E778ABCD025953A73@AMSPEX01CL01.citrite.net> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Paul Durrant Cc: Andrew Cooper , "Keir(Xen.org)" , "xen-devel@lists.xenproject.org" List-Id: xen-devel@lists.xenproject.org >>> On 17.06.15 at 18:30, wrote: >> From: Jan Beulich [mailto:JBeulich@suse.com] >> Sent: 17 June 2015 16:51 >> >>> On 11.06.15 at 17:42, wrote: >> > --- a/xen/arch/x86/hvm/emulate.c >> > +++ b/xen/arch/x86/hvm/emulate.c >> > @@ -273,6 +273,15 @@ static int hvmemul_acquire_page(unsigned long >> gmfn, struct page_info **page) >> > return X86EMUL_RETRY; >> > } >> > >> > + /* This code should not be reached if the gmfn is not RAM */ >> > + if ( p2m_is_mmio(p2mt) ) >> > + { >> > + domain_crash(d); >> >> Log a message at least? Silent domain death is rather ugly to analyze. > > You do get a file+line (since domain_crash is actually a macro with a printk > in it too) but I can also log something. Ah, right, I forgot about that. No extra message necessary then I guess. Jan