From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 23/27] tools/libxl: [RFC] Write checkpoint
 records into the stream
Date: Thu, 18 Jun 2015 10:44:01 +0100
Message-ID: <558292E1.6060703@citrix.com>
References: <1434375880-30914-1-git-send-email-andrew.cooper3@citrix.com>
	<1434375880-30914-24-git-send-email-andrew.cooper3@citrix.com>
	<55823770.9040801@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55823770.9040801@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wen Congyang <wency@cn.fujitsu.com>, Xen-devel <xen-devel@lists.xen.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 18/06/15 04:13, Wen Congyang wrote:
>> @@ -139,6 +169,15 @@ static void stream_failed(libxl__egc *egc,
>> >      assert(rc);
>> >      stream->rc = rc;
>> >  
>> > +    /*
>> > +     *If we are in a checkpoint, pass the failure to libxc, which will come
>> > +     * back around to us via libxl__xc_domain_save_done().
>> > +     */
>> > +    if (stream->in_checkpoint) {
> I think we should set running to false here too.
>
> Thanks
> Wen Congyang
>

"running" encapsulates that a stream is being written, which includes
time when libxc is writing into the fd below us.

In particular, setting running to false here will prevent the stream
from being correctly torn down if the libxl-save-helper process
encounters an error.

~Andrew