From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCHv3 4/6] evtchn: use a per-event channel lock
 for sending events
Date: Thu, 18 Jun 2015 12:39:45 +0100
Message-ID: <5582AE01.9000403@citrix.com>
References: <1434542583-28073-1-git-send-email-david.vrabel@citrix.com>
	<1434542583-28073-5-git-send-email-david.vrabel@citrix.com>
	<5582C58C020000780008692C@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6045ec3c1=david.vrabel@citrix.com>)
	id 1Z5YAh-0003sj-Gs
	for xen-devel@lists.xenproject.org; Thu, 18 Jun 2015 11:39:51 +0000
In-Reply-To: <5582C58C020000780008692C@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 18/06/15 12:20, Jan Beulich wrote:
>>>> On 17.06.15 at 14:03, <david.vrabel@citrix.com> wrote:
>> When sending an event, use a new per-event channel lock to safely
>> validate the event channel state.
>>
>> This new lock must be held when changing event channel state.  Note
>> that the event channel lock must also be held when changing state from
>> ECS_FREE or it will race with a concurrent get_free_port() call.
>>
>> To avoid having to take the remote event channel locks when sending to
>> an interdomain event channel, the local and remote channel locks are
>> both held when binding or closing an interdomain event channel.
>>
>> This significantly  increases the  number of events  that can  be sent
>> from multiple  VCPUs.  But struct  evtchn increases in  size, reducing
>> the number that fit into a single page to 64 (instead of 128).
>>
>> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> 
> But iiuc this functionally depends on the earlier patches, and
> hence can't go in without the issues there addressed.

Yes, this depends on #1, #2 and #3.

David