From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932070AbbFRMRq (ORCPT ); Thu, 18 Jun 2015 08:17:46 -0400 Received: from emvm-gh1-uea09.nsa.gov ([63.239.67.10]:61216 "EHLO emvm-gh1-uea09.nsa.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752331AbbFRMRg (ORCPT ); Thu, 18 Jun 2015 08:17:36 -0400 X-TM-IMSS-Message-ID: Message-ID: <5582B69D.3010208@tycho.nsa.gov> Date: Thu, 18 Jun 2015 08:16:29 -0400 From: Stephen Smalley Organization: National Security Agency User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: David Howells CC: linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, drquigl , linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 5/7] SELinux: Handle opening of a unioned file References: <55805AEA.3050407@tycho.nsa.gov> <557ECBC5.7000705@tycho.nsa.gov> <16216.1417109138@warthog.procyon.org.uk> <545A51CB.6070107@tycho.nsa.gov> <20141105154217.2555.578.stgit@warthog.procyon.org.uk> <20141105154307.2555.9847.stgit@warthog.procyon.org.uk> <8813.1434123054@warthog.procyon.org.uk> <7332.1434473388@warthog.procyon.org.uk> <8458.1434623534@warthog.procyon.org.uk> In-Reply-To: <8458.1434623534@warthog.procyon.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/18/2015 06:32 AM, David Howells wrote: > Stephen Smalley wrote: > >> It is may_create() that has the duplicated logic > > Not precisely. may_create() doesn't use SECURITY_FS_USE_MNTPOINT and > sbsec->mntpoint_sid. Should it? Yes, they should all use exactly the same logic. From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <5582B69D.3010208@tycho.nsa.gov> Date: Thu, 18 Jun 2015 08:16:29 -0400 From: Stephen Smalley MIME-Version: 1.0 To: David Howells Subject: Re: [PATCH 5/7] SELinux: Handle opening of a unioned file References: <55805AEA.3050407@tycho.nsa.gov> <557ECBC5.7000705@tycho.nsa.gov> <16216.1417109138@warthog.procyon.org.uk> <545A51CB.6070107@tycho.nsa.gov> <20141105154217.2555.578.stgit@warthog.procyon.org.uk> <20141105154307.2555.9847.stgit@warthog.procyon.org.uk> <8813.1434123054@warthog.procyon.org.uk> <7332.1434473388@warthog.procyon.org.uk> <8458.1434623534@warthog.procyon.org.uk> In-Reply-To: <8458.1434623534@warthog.procyon.org.uk> Content-Type: text/plain; charset=windows-1252 Cc: linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, drquigl List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: On 06/18/2015 06:32 AM, David Howells wrote: > Stephen Smalley wrote: > >> It is may_create() that has the duplicated logic > > Not precisely. may_create() doesn't use SECURITY_FS_USE_MNTPOINT and > sbsec->mntpoint_sid. Should it? Yes, they should all use exactly the same logic.