From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCHv3 2/6] evtchn: defer freeing struct evtchn's
 until evtchn_destroy_final()
Date: Thu, 18 Jun 2015 11:36:28 +0100
Message-ID: <5582BB4C02000078000868FB@mail.emea.novell.com>
References: <1434542583-28073-1-git-send-email-david.vrabel@citrix.com>
	<1434542583-28073-3-git-send-email-david.vrabel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <JBeulich@suse.com>) id 1Z5XBP-0003h0-P7
	for xen-devel@lists.xenproject.org; Thu, 18 Jun 2015 10:36:31 +0000
In-Reply-To: <1434542583-28073-3-git-send-email-david.vrabel@citrix.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

>>> On 17.06.15 at 14:02, <david.vrabel@citrix.com> wrote:
> --- a/xen/common/event_channel.c
> +++ b/xen/common/event_channel.c
> @@ -1175,22 +1175,6 @@ int alloc_unbound_xen_event_channel(
>  
>  void free_xen_event_channel(struct domain *d, int port)
>  {
> -    struct evtchn *chn;
> -
> -    spin_lock(&d->event_lock);
> -
> -    if ( unlikely(d->is_dying) )
> -    {
> -        spin_unlock(&d->event_lock);
> -        return;
> -    }
> -
> -    BUG_ON(!port_is_valid(d, port));
> -    chn = evtchn_from_port(d, port);
> -    BUG_ON(!consumer_is_xen(chn));

At least in debug builds I think these would better be retained.

Jan