From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5aAa-0001Mh-9R for qemu-devel@nongnu.org; Thu, 18 Jun 2015 09:47:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5aAU-0004Tj-BX for qemu-devel@nongnu.org; Thu, 18 Jun 2015 09:47:52 -0400 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:35169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5aAU-0004Qc-4W for qemu-devel@nongnu.org; Thu, 18 Jun 2015 09:47:46 -0400 Received: by wgbhy7 with SMTP id hy7so64352812wgb.2 for ; Thu, 18 Jun 2015 06:47:44 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5582CBFD.8090604@redhat.com> Date: Thu, 18 Jun 2015 15:47:41 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1434545105-5811-1-git-send-email-lersek@redhat.com> <1434545105-5811-4-git-send-email-lersek@redhat.com> <20150617154135-mutt-send-email-mst@redhat.com> <55817C54.1000201@redhat.com> <20150617155751-mutt-send-email-mst@redhat.com> In-Reply-To: <20150617155751-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 3/7] hw/pci-bridge: introduce "hotplug" property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Laszlo Ersek Cc: Marcel Apfelbaum , qemu-devel@nongnu.org On 17/06/2015 16:02, Michael S. Tsirkin wrote: > > Are you okay with the flag's name, PCI_BRIDGE_DEV_F_HOTPLUG? If not, > > what would be your preference? > > PCI_BRIDGE_DEV_F_SHPC_REQ Do not abbrev unless necessary. :) What about PCI_BRIDGE_DEV_F_HAS_SHPC or even just PCI_BRIDGE_DEV_F_SHPC? Paolo > Also add macro for "shpc" property string to avoid duplication. > Also clear msi explicitly - no need for that to depend on shpc. >