From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 12/22] fjes: net_device_ops.ndo_get_stats64 Date: Thu, 18 Jun 2015 17:00:52 +0300 Message-ID: <5582CF14.3040507@cogentembedded.com> References: <1434588359-25589-1-git-send-email-izumi.taku@jp.fujitsu.com> <1434588587-25655-1-git-send-email-izumi.taku@jp.fujitsu.com> <1434588587-25655-12-git-send-email-izumi.taku@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1434588587-25655-12-git-send-email-izumi.taku@jp.fujitsu.com> Sender: platform-driver-x86-owner@vger.kernel.org To: Taku Izumi , platform-driver-x86@vger.kernel.org, dvhart@infradead.org Cc: rkhan@redhat.com, alexander.h.duyck@redhat.com, netdev@vger.kernel.org, linux-acpi@vger.kernel.org List-Id: linux-acpi@vger.kernel.org Hello. On 6/18/2015 3:49 AM, Taku Izumi wrote: > This patch adds net_device_ops.ndo_get_stats64 callback. > Signed-off-by: Taku Izumi > --- > drivers/platform/x86/fjes/fjes_main.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > diff --git a/drivers/platform/x86/fjes/fjes_main.c b/drivers/platform/x86/fjes/fjes_main.c > index 97bf487..eeda824 100644 > --- a/drivers/platform/x86/fjes/fjes_main.c > +++ b/drivers/platform/x86/fjes/fjes_main.c > @@ -57,6 +57,8 @@ static netdev_tx_t fjes_xmit_frame(struct sk_buff *, > static void fjes_raise_intr_rxdata_task(struct work_struct *); > static void fjes_tx_stall_task(struct work_struct *); > static irqreturn_t fjes_intr(int, void*); > +static struct rtnl_link_stats64 > +*fjes_get_stats64(struct net_device *, struct rtnl_link_stats64 *); I'd leave * on the first line, otherwise it looks quite ugly.. [...] > @@ -734,6 +737,17 @@ static netdev_tx_t fjes_xmit_frame(struct sk_buff *skb, > return ret; > } > > +static struct rtnl_link_stats64 > +*fjes_get_stats64(struct net_device *netdev, Same here. [...] WBR, Sergei