From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: sfeldma@gmail.com, netdev@vger.kernel.org
Cc: jiri@resnulli.us, simon.horman@netronome.com,
roopa@cumulusnetworks.com, ronen.arad@intel.com,
john.r.fastabend@intel.com, andrew@lunn.ch, f.fainelli@gmail.com,
linux@roeck-us.net, davidch@broadcom.com,
stephen@networkplumber.org
Subject: Re: [RFC PATCH net-next v2 2/5] net: add phys ID compare helper to test if two IDs are the same
Date: Thu, 18 Jun 2015 17:11:14 +0300 [thread overview]
Message-ID: <5582D182.80803@cogentembedded.com> (raw)
In-Reply-To: <1434577994-22409-3-git-send-email-sfeldma@gmail.com>
Hello.
On 6/18/2015 12:53 AM, sfeldma@gmail.com wrote:
> From: Scott Feldman <sfeldma@gmail.com>
> Signed-off-by: Scott Feldman <sfeldma@gmail.com>
> ---
> include/linux/netdevice.h | 7 +++++++
> net/switchdev/switchdev.c | 8 ++------
> 2 files changed, 9 insertions(+), 6 deletions(-)
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 7be616e1..63090ce 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -766,6 +766,13 @@ struct netdev_phys_item_id {
> unsigned char id_len;
> };
>
> +static inline bool netdev_phys_item_id_same(struct netdev_phys_item_id *a,
> + struct netdev_phys_item_id *b)
> +{
> + return ((a->id_len == b->id_len) &&
> + (memcmp(a->id, b->id, a->id_len) == 0));
Parens around the *return* expression not needed (and neither the ones
around ==).
[...]
WBR, Sergei
next prev parent reply other threads:[~2015-06-18 14:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 21:53 [RFC PATCH net-next v2 0/5] switchdev: avoid duplicate packet forwarding sfeldma
2015-06-17 21:53 ` [RFC PATCH net-next v2 1/5] net: don't reforward packets already forwarded by offload device sfeldma
2015-06-17 21:53 ` [RFC PATCH net-next v2 2/5] net: add phys ID compare helper to test if two IDs are the same sfeldma
2015-06-18 14:11 ` Sergei Shtylyov [this message]
2015-06-17 21:53 ` [RFC PATCH net-next v2 3/5] switchdev: add offload_fwd_mark generator helper sfeldma
2015-06-17 21:53 ` [RFC PATCH net-next v2 4/5] rocker: add offload_fwd_mark support sfeldma
2015-06-17 21:53 ` [RFC PATCH net-next v2 5/5] switchdev: update documentation for offload_fwd_mark sfeldma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5582D182.80803@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=andrew@lunn.ch \
--cc=davidch@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=john.r.fastabend@intel.com \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=ronen.arad@intel.com \
--cc=roopa@cumulusnetworks.com \
--cc=sfeldma@gmail.com \
--cc=simon.horman@netronome.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.