From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755845AbbFROzT (ORCPT <rfc822;w@1wt.eu>);
	Thu, 18 Jun 2015 10:55:19 -0400
Received: from mga01.intel.com ([192.55.52.88]:57879 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754121AbbFROzM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 18 Jun 2015 10:55:12 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,638,1427785200"; 
   d="scan'208";a="510389926"
Message-ID: <5582DBC9.6070606@intel.com>
Date: Thu, 18 Jun 2015 07:55:05 -0700
From: Tadeusz Struk <tadeusz.struk@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Andreas Ruprecht <andreas.ruprecht@fau.de>
CC: Herbert Xu <herbert@gondor.apana.org.au>,
        Valentin Rothberg <valentinrothberg@gmail.com>,
        Paul Bolle <pebolle@tiscali.nl>,
        Stefan Hengelein <stefan.hengelein@fau.de>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: crypto: rsa - select on undefined AKCIPHER
References: <5582809E.4060002@fau.de>
In-Reply-To: <5582809E.4060002@fau.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/18/2015 01:26 AM, Andreas Ruprecht wrote:
> Hi Tadeusz,
> 
> your commit cfc2bb32b313 ("crypto: rsa - add a new rsa generic
> implementation") was merged into linux-next today (i.e., next-20150618).
> It changes the crypto/Kconfig file and adds the CRYPTO_RSA config option:
> 
> +config CRYPTO_RSA
> +	tristate "RSA algorithm"
> +	select AKCIPHER
> [...]
> 
> The symbol AKCIPHER, however, is not defined in Kconfig. Did you maybe
> mean CRYPTO_AKCIPHER, which you added in commit 3c339ab83fc0 ("crypto:
> akcipher - add PKE API")?
> 
> I detected the issue by running undertaker-checkpatch from the
> Undertaker tool suite (https://undertaker.cs.fau.de) as part of an
> automated, daily analysis of the most recent linux-next tree.
> There is also a tool in the Linux tree itself that can detect such
> issues (scripts/checkkconfigsymbols.py).
Hi Andreas,
Yes it should have been CRYPTO_AKCIPHER.
Thanks for reporting this.

--- >8 ---
This patch fixes invalid config selection for AKCIPHER

Reported-by: Andreas Ruprecht <andreas.ruprecht@fau.de>
Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
---

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 6c79ef0..b4cfc57 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -102,7 +102,7 @@ config CRYPTO_AKCIPHER
 
 config CRYPTO_RSA
        tristate "RSA algorithm"
-       select AKCIPHER
+       select CRYPTO_AKCIPHER
        select MPILIB
        select ASN1
        help