From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756235AbbFRQXx (ORCPT ); Thu, 18 Jun 2015 12:23:53 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:37128 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754828AbbFRQXp (ORCPT ); Thu, 18 Jun 2015 12:23:45 -0400 Message-ID: <5582F086.30301@tronnes.org> Date: Thu, 18 Jun 2015 18:23:34 +0200 From: =?UTF-8?B?Tm9yYWxmIFRyw7hubmVz?= User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stephen Warren CC: linux-kernel@vger.kernel.org, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH] irqchip: bcm2835: Add FIQ support References: <1434130016-26574-1-git-send-email-noralf@tronnes.org> <55822C71.2040409@wwwdotorg.org> <5582C87C.20008@tronnes.org> In-Reply-To: <5582C87C.20008@tronnes.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 18.06.2015 15:32, skrev Noralf Trønnes: > > Den 18.06.2015 04:26, skrev Stephen Warren: >> On 06/12/2015 11:26 AM, Noralf Trønnes wrote: >>> Add a duplicate irq range with an offset on the hwirq's so the >>> driver can detect that enable_fiq() is used. >>> Tested with downstream dwc_otg USB controller driver. >> This basically looks OK, but a few comments/thoughts: >> >> c) The DT binding needs updating to describe the extra IRQs: >> >>> Documentation/devicetree/bindings/interrupt-controller/brcm,bcm28armctrl-ic.txt >>> > > Ok. > I have seconds thoughts on this: This patch does not change the DT bindings so I don't see what update I should make. This patch only adds support for the Linux way of handling FIQ's through enable_fiq(). It doesn't change how interrupts are described in the DT. From mboxrd@z Thu Jan 1 00:00:00 1970 From: noralf@tronnes.org (=?UTF-8?B?Tm9yYWxmIFRyw7hubmVz?=) Date: Thu, 18 Jun 2015 18:23:34 +0200 Subject: [PATCH] irqchip: bcm2835: Add FIQ support In-Reply-To: <5582C87C.20008@tronnes.org> References: <1434130016-26574-1-git-send-email-noralf@tronnes.org> <55822C71.2040409@wwwdotorg.org> <5582C87C.20008@tronnes.org> Message-ID: <5582F086.30301@tronnes.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Den 18.06.2015 15:32, skrev Noralf Tr?nnes: > > Den 18.06.2015 04:26, skrev Stephen Warren: >> On 06/12/2015 11:26 AM, Noralf Tr?nnes wrote: >>> Add a duplicate irq range with an offset on the hwirq's so the >>> driver can detect that enable_fiq() is used. >>> Tested with downstream dwc_otg USB controller driver. >> This basically looks OK, but a few comments/thoughts: >> >> c) The DT binding needs updating to describe the extra IRQs: >> >>> Documentation/devicetree/bindings/interrupt-controller/brcm,bcm28armctrl-ic.txt >>> > > Ok. > I have seconds thoughts on this: This patch does not change the DT bindings so I don't see what update I should make. This patch only adds support for the Linux way of handling FIQ's through enable_fiq(). It doesn't change how interrupts are described in the DT.