From: "Jan Beulich" <JBeulich@suse.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: andrew.cooper3@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v3 06/11] x86/intel_pstate: the main boby of the intel_pstate driver
Date: Thu, 18 Jun 2015 16:03:27 +0100 [thread overview]
Message-ID: <5582F9DF0200007800086B22@mail.emea.novell.com> (raw)
In-Reply-To: <1434011265-17256-1-git-send-email-wei.w.wang@intel.com>
>>> On 11.06.15 at 10:27, <wei.w.wang@intel.com> wrote:
> The intel_pstate driver is ported following its kernel code logic
> (commit: 93f0822d).In order to port the Linux source file with
> minimal modifications, some of the variable types are kept intact
> (e.g. "int current_pstae", would otherwise be changed to
> "unsigned int").
Minimal modifications implies no whitespace changes either (and
even less so indentation corruption, like I just spotted in
ceiling_fp() and pid_calc(); I didn't look further). I.e. if you aim
at that, a diff between the original and the Xen clone should be
reasonably small (and that's what I'd likely look at in the end, as
I then don't really want to review all code which already made it
into upstream Linux).
> --- a/xen/arch/x86/cpu/common.c
> +++ b/xen/arch/x86/cpu/common.c
> @@ -238,6 +238,9 @@ static void __cpuinit generic_identify(struct cpuinfo_x86 *c)
> if ( cpu_has(c, X86_FEATURE_CLFLSH) )
> c->x86_clflush_size = ((ebx >> 8) & 0xff) * 8;
>
> + if (cpuid_ecx(6) & 0x1)
> + set_bit(X86_FEATURE_APERFMPERF, c->x86_capability);
With that the kind of misplaced identical code pieces in cpufreq.c
and powernow.c should go away. The three changes together
would probably best be broken out to a separate patch, to keep
the focus on this one on the introduction of intel_pstate.c.
Jan
prev parent reply other threads:[~2015-06-18 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 8:27 [PATCH v3 06/11] x86/intel_pstate: the main boby of the intel_pstate driver Wei Wang
2015-06-11 14:00 ` Julien Grall
2015-06-12 1:41 ` Wang, Wei W
2015-06-12 11:29 ` Julien Grall
2015-06-15 0:30 ` Wang, Wei W
2015-06-15 9:11 ` Jan Beulich
2015-06-18 15:03 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5582F9DF0200007800086B22@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.w.wang@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.