From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 01/15] drm/i915: Add i915_gem_object_write() to i915_gem.c Date: Thu, 18 Jun 2015 19:07:46 +0100 Message-ID: <558308F2.6040809@intel.com> References: <1434393394-21002-1-git-send-email-david.s.gordon@intel.com> <1434393394-21002-2-git-send-email-david.s.gordon@intel.com> <20150615200910.GE28462@nuc-i3427.alporthouse.com> <5581207C.8050305@intel.com> <20150617120211.GQ23637@phenom.ffwll.local> <5582B063.6060700@intel.com> <20150618121034.GL24012@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id DCDA36ED93 for ; Thu, 18 Jun 2015 11:07:50 -0700 (PDT) In-Reply-To: <20150618121034.GL24012@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTgvMDYvMTUgMTM6MTAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBUaHUsIEp1biAxOCwg MjAxNSBhdCAxMjo0OTo1NVBNICswMTAwLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gT24gMTcvMDYv MTUgMTM6MDIsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4+PiBEb21haW4gaGFuZGxpbmcgaXMgcmVx dWlyZWQgZm9yIGFsbCBnZW0gb2JqZWN0cywgYW5kIHRoZSByZXN1bHRpbmcgYnVncyBpZgo+Pj4g eW91IGRvbid0IGZvciBvbmUtb2ZmIG9iamVjdHMgYXJlIGFic29sdXRlbHkgbm8gZnVuIHRvIHRy YWNrIGRvd24uCj4+Cj4+IElzIGl0IG5vdCB0aGUgY2FzZSB0aGF0IHRoZSBuZXcgb2JqZWN0IHJl dHVybmVkIGJ5Cj4+IGk5MTVfZ2VtX2FsbG9jX29iamVjdCgpIGlzCj4+IChhKSBvZiBhIHR5cGUg dGhhdCBjYW4gYmUgbWFwcGVkIGludG8gdGhlIEdUVCwgYW5kCj4+IChiKSBpbml0aWFsbHkgaW4g dGhlIENQVSBkb21haW4gZm9yIGJvdGggcmVhZGluZyBhbmQgd3JpdGluZz8KPj4KPj4gU28gQUZB SUNTIHRoZSBhbGxvY2F0ZS1hbmQtZmlsbCBmdW5jdGlvbiBJJ20gZGVzY3JpYmluZyAodG8gYXBw ZWFyIGluCj4+IG5leHQgcGF0Y2ggc2VyaWVzIHJlc3BpbikgZG9lc24ndCBuZWVkIGFueSBmdXJ0 aGVyIGRvbWFpbiBoYW5kbGluZy4KPiAKPiBBIGk5MTVfZ2VtX29iamVjdF9jcmVhdGVfZnJvbV9k YXRhKCkgaXMgYSByZWFzb25hYmxlIGFkZGl0aW9uLCBhbmQgSQo+IHN1c3BlY3QgaXQgd2lsbCBt YWtlIHRoZSBjb2RlIGEgYml0IG1vcmUgc3VjY2luY3QuCgpJIHNoYWxsIGFkb3B0IHRoaXMgbmFt ZSBmb3IgaXQgOikKCj4gV2hpbHN0IHlvdXIgc3RhdGVtZW50IGlzIHRydWUgdG9kYXksIGNhbGxp bmcgc2V0X2RvbWFpbiBpcyB0aGVuIGEgbm8tb3AsCj4gYW5kIGhlbHBzIGRvY3VtZW50IGhvdyB5 b3UgdXNlIHRoZSBvYmplY3QgYW5kIHNvIHJlZHVjZXMgdGhlIGxpa2VsaWhvb2QKPiBvZiB1cyBp bnRyb2R1Y2luZyBidWdzIGluIHRoZSBmdXR1cmUuCj4gLUNocmlzCgpTbyBoZXJlJ3MgdGhlIG5l dyBmdW5jdGlvbiAuLi4gd2hlcmUgc2hvdWxkIHRoZSBzZXQtdG8tY3B1LWRvbWFpbiBnbz8KQWZ0 ZXIgdGhlIHBpbl9wYWdlcyBhbmQgYmVmb3JlIHRoZSBzZ19jb3B5X2Zyb21fYnVmZmVyPwoKLyog QWxsb2NhdGUgYSBuZXcgR0VNIG9iamVjdCBhbmQgZmlsbCBpdCB3aXRoIHRoZSBzdXBwbGllZCBk YXRhICovCnN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICoKaTkxNV9nZW1fb2JqZWN0X2NyZWF0 ZV9mcm9tX2RhdGEoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY29uc3Qgdm9pZCAqZGF0YSwgc2l6ZV90IHNpemUpCnsKICAgICAgICBzdHJ1 Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqOwogICAgICAgIHN0cnVjdCBzZ190YWJsZSAqc2c7 CiAgICAgICAgc2l6ZV90IGJ5dGVzOwogICAgICAgIGludCByZXQ7CgogICAgICAgIG9iaiA9IGk5 MTVfZ2VtX2FsbG9jX29iamVjdChkZXYsIHJvdW5kX3VwKHNpemUsIFBBR0VfU0laRSkpOwogICAg ICAgIGlmICghb2JqKQogICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7CgogICAgICAgIHJldCA9 IGk5MTVfZ2VtX29iamVjdF9nZXRfcGFnZXMob2JqKTsKICAgICAgICBpZiAocmV0KQogICAgICAg ICAgICAgICAgZ290byBmYWlsOwoKICAgICAgICBpOTE1X2dlbV9vYmplY3RfcGluX3BhZ2VzKG9i aik7CiAgICAgICAgc2cgPSBvYmotPnBhZ2VzOwogICAgICAgIGJ5dGVzID0gc2dfY29weV9mcm9t X2J1ZmZlcihzZy0+c2dsLCBzZy0+bmVudHMsICh2b2lkICopZGF0YSwgc2l6ZSk7CiAgICAgICAg aTkxNV9nZW1fb2JqZWN0X3VucGluX3BhZ2VzKG9iaik7CgogICAgICAgIGlmIChXQVJOX09OKGJ5 dGVzICE9IHNpemUpKSB7CiAgICAgICAgICAgICAgICBEUk1fRVJST1IoIkluY29tcGxldGUgY29w eSwgd3JvdGUgJXp1IG9mICV6dSIsIGJ5dGVzLCBzaXplKTsKICAgICAgICAgICAgICAgIGdvdG8g ZmFpbDsKICAgICAgICB9CgogICAgICAgIHJldHVybiBvYmo7CgpmYWlsOgogICAgICAgIGRybV9n ZW1fb2JqZWN0X3VucmVmZXJlbmNlKCZvYmotPmJhc2UpOwogICAgICAgIHJldHVybiBOVUxMOwp9 CgouRGF2ZS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK