From: Eric Blake <eblake@redhat.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] vvfat: add a label option
Date: Thu, 18 Jun 2015 15:01:39 -0600 [thread overview]
Message-ID: <558331B3.9050304@redhat.com> (raw)
In-Reply-To: <1434636521-24426-1-git-send-email-w.bumiller@proxmox.com>
[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]
On 06/18/2015 08:08 AM, Wolfgang Bumiller wrote:
> Till now the vvfat filesystem's label was hardcoded to be
s/Till/Until/
> "QEMU VVFAT", now you can pass a file.label=labelname option
> to the -drive to change it.
>
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
> block/vvfat.c | 25 ++++++++++++++++++++++---
> qapi/block-core.json | 3 ++-
> 2 files changed, 24 insertions(+), 4 deletions(-)
>
> +++ b/qapi/block-core.json
> @@ -1453,13 +1453,14 @@
> # @fat-type: #optional FAT type: 12, 16 or 32
> # @floppy: #optional whether to export a floppy image (true) or
> # partitioned hard disk (false; default)
> +# @label: #optional override default label
Missing '(since 2.4)', and also a description of the default text, as
well as the fact that the text is limited to 11 bytes. Not sure if it
is also worth mentioning that shorter strings padded with trailing
spaces to the proper length.
Otherwise looks reasonable.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-06-18 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 14:08 [Qemu-devel] [PATCH] vvfat: add a label option Wolfgang Bumiller
2015-06-18 16:09 ` Stefan Hajnoczi
2015-06-18 21:01 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558331B3.9050304@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.