From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5tbi-0005Bx-3Y for qemu-devel@nongnu.org; Fri, 19 Jun 2015 06:33:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5tbe-0008J0-UO for qemu-devel@nongnu.org; Fri, 19 Jun 2015 06:33:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36028) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5tbe-0008Io-P2 for qemu-devel@nongnu.org; Fri, 19 Jun 2015 06:33:06 -0400 Message-ID: <5583EFD4.1000206@redhat.com> Date: Fri, 19 Jun 2015 12:32:52 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1434028716-6767-1-git-send-email-den@openvz.org> <1434028716-6767-2-git-send-email-den@openvz.org> <55816BA1.7010900@redhat.com> <1434709729.31471.3.camel@virtuozzo.com> In-Reply-To: <1434709729.31471.3.camel@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V based guest crash data handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: asmetanin@virtuozzo.com Cc: Gleb Natapov , "Denis V. Lunev" , qemu-devel@nongnu.org, kvm@vger.kernel.org On 19/06/2015 12:28, Andrey Smetanin wrote: > On Wed, 2015-06-17 at 14:44 +0200, Paolo Bonzini wrote: >> >> On 11/06/2015 15:18, Denis V. Lunev wrote: >>> From: Andrey Smetanin >>> >>> Windows 2012 guests can notify hypervisor about occurred guest crash >>> (Windows bugcheck(BSOD)) by writing specific Hyper-V msrs. This patch does >>> handling of this MSR's by KVM and sending notification to user space that >>> allows to gather Windows guest crash dump by QEMU/LIBVIRT. >>> >>> The idea is to provide functionality equal to pvpanic device without >>> QEMU guest agent for Windows. >>> >>> The idea is borrowed from Linux HyperV bus driver and validated against >>> Windows 2k12. >>> >>> Signed-off-by: Andrey Smetanin >>> Signed-off-by: Denis V. Lunev >>> CC: Gleb Natapov >>> CC: Paolo Bonzini >>> --- >>> arch/x86/include/uapi/asm/hyperv.h | 10 +++++ >>> arch/x86/kvm/Makefile | 2 +- >>> arch/x86/kvm/mshv.c | 84 ++++++++++++++++++++++++++++++++++++++ >>> arch/x86/kvm/mshv.h | 32 +++++++++++++++ >> >> Please use hyperv.[ch] or hyper-v.[ch] and name the functions kvm_hv_*. >> We can later move more functions from x86.c to the new file, so it's >> better to keep the names consistent. >> > Should we prepare a 1st patch in this series where > we move all hyper-v related code from x86.c into hyperv.c new file with > copyright extension ? If you want to do that, I certainly wouldn't complain. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 1/2] kvm/x86: Hyper-V based guest crash data handling Date: Fri, 19 Jun 2015 12:32:52 +0200 Message-ID: <5583EFD4.1000206@redhat.com> References: <1434028716-6767-1-git-send-email-den@openvz.org> <1434028716-6767-2-git-send-email-den@openvz.org> <55816BA1.7010900@redhat.com> <1434709729.31471.3.camel@virtuozzo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , "Denis V. Lunev" , qemu-devel@nongnu.org, kvm@vger.kernel.org To: asmetanin@virtuozzo.com Return-path: In-Reply-To: <1434709729.31471.3.camel@virtuozzo.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 19/06/2015 12:28, Andrey Smetanin wrote: > On Wed, 2015-06-17 at 14:44 +0200, Paolo Bonzini wrote: >> >> On 11/06/2015 15:18, Denis V. Lunev wrote: >>> From: Andrey Smetanin >>> >>> Windows 2012 guests can notify hypervisor about occurred guest crash >>> (Windows bugcheck(BSOD)) by writing specific Hyper-V msrs. This patch does >>> handling of this MSR's by KVM and sending notification to user space that >>> allows to gather Windows guest crash dump by QEMU/LIBVIRT. >>> >>> The idea is to provide functionality equal to pvpanic device without >>> QEMU guest agent for Windows. >>> >>> The idea is borrowed from Linux HyperV bus driver and validated against >>> Windows 2k12. >>> >>> Signed-off-by: Andrey Smetanin >>> Signed-off-by: Denis V. Lunev >>> CC: Gleb Natapov >>> CC: Paolo Bonzini >>> --- >>> arch/x86/include/uapi/asm/hyperv.h | 10 +++++ >>> arch/x86/kvm/Makefile | 2 +- >>> arch/x86/kvm/mshv.c | 84 ++++++++++++++++++++++++++++++++++++++ >>> arch/x86/kvm/mshv.h | 32 +++++++++++++++ >> >> Please use hyperv.[ch] or hyper-v.[ch] and name the functions kvm_hv_*. >> We can later move more functions from x86.c to the new file, so it's >> better to keep the names consistent. >> > Should we prepare a 1st patch in this series where > we move all hyper-v related code from x86.c into hyperv.c new file with > copyright extension ? If you want to do that, I certainly wouldn't complain. Paolo