From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5vWv-0004Ms-NC for qemu-devel@nongnu.org; Fri, 19 Jun 2015 08:36:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5vWr-0007Og-KP for qemu-devel@nongnu.org; Fri, 19 Jun 2015 08:36:21 -0400 Received: from cantor2.suse.de ([195.135.220.15]:42518 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5vWr-0007O1-ED for qemu-devel@nongnu.org; Fri, 19 Jun 2015 08:36:17 -0400 Message-ID: <55840CC0.3070207@suse.de> Date: Fri, 19 Jun 2015 14:36:16 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1434194302-26589-1-git-send-email-armbru@redhat.com> <1434194302-26589-2-git-send-email-armbru@redhat.com> In-Reply-To: <1434194302-26589-2-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/7] qdev: Deprecated qdev_init() is finally unused, drop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, kraxel@redhat.com Hi Markus, Could you please add a verbose rationale here like "qdev_init() does not propagate the Error* and should be replaced by ..."? Am 13.06.2015 um 13:18 schrieb Markus Armbruster: > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > hw/core/qdev.c | 47 ++++++++++++++++--------------------------= ----- > include/hw/qdev-core.h | 3 +-- > 2 files changed, 17 insertions(+), 33 deletions(-) Otherwise, Reviewed-by: Andreas F=E4rber Thanks, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)