From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5vcc-0000ob-HH for qemu-devel@nongnu.org; Fri, 19 Jun 2015 08:42:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5vcX-00052C-FN for qemu-devel@nongnu.org; Fri, 19 Jun 2015 08:42:14 -0400 Received: from cantor2.suse.de ([195.135.220.15]:42849 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5vcX-00050T-9Z for qemu-devel@nongnu.org; Fri, 19 Jun 2015 08:42:09 -0400 Message-ID: <55840E20.5010300@suse.de> Date: Fri, 19 Jun 2015 14:42:08 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1434194302-26589-1-git-send-email-armbru@redhat.com> <1434194302-26589-3-git-send-email-armbru@redhat.com> In-Reply-To: <1434194302-26589-3-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/7] qdev: Un-deprecate qdev_init_nofail() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, kraxel@redhat.com Am 13.06.2015 um 13:18 schrieb Markus Armbruster: > It's a perfectly sensible helper function. But only in the current state. Once/if we just set realized=3Dtrue on /machine level, then no other helper functions will need to set it, as pointed out in the following paragraph. >=20 > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > include/hw/qdev-core.h | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > index 5789b91..fbfc741 100644 > --- a/include/hw/qdev-core.h > +++ b/include/hw/qdev-core.h > @@ -65,8 +65,6 @@ struct VMStateDescription; > * Operations depending on @props static properties should go into @re= alize. > * After successful realization, setting static properties will fail. > * > - * As an interim step, the #DeviceState:realized property is set by de= precated > - * function qdev_init_nofail(). > * In the future, devices will propagate this state change to their ch= ildren > * and along busses they expose. > * The point in time will be deferred to machine creation, so that val= ues Nack to the patch as is. I would be much more open to it if you just removed the word "deprecated" rather than the full paragraph explaining where it is currently set. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)