From: Lars-Peter Clausen <lars@metafoo.de>
To: jmfriedt@femto-st.fr, linux-iio@vger.kernel.org
Cc: Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de,
pmeerw@pmeerw.net
Subject: Re: [PATCH 1/1] iio: DAC: ad5624r_spi: fix bit shift of output data value
Date: Fri, 19 Jun 2015 14:56:19 +0200 [thread overview]
Message-ID: <55841173.30506@metafoo.de> (raw)
In-Reply-To: <1434718086-14722-1-git-send-email-jmfriedt@femto-st.fr>
On 06/19/2015 02:48 PM, jmfriedt@femto-st.fr wrote:
> From: JM Friedt <jmfriedt@femto-st.fr>
>
> The value sent on the SPI bus is shifted by an erroneous number of bits. The shift
> value was already computed in the iio_chan_spec structure and hence subtracting this
> argument to 16 yields an erroneous data position in the SPI stream.
>
> Signed-off-by: JM Friedt <jmfriedt@femto-st.fr>
Looks good, thanks.
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> drivers/iio/dac/ad5624r_spi.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/dac/ad5624r_spi.c b/drivers/iio/dac/ad5624r_spi.c
> index 61bb9d4..e98428d 100644
> --- a/drivers/iio/dac/ad5624r_spi.c
> +++ b/drivers/iio/dac/ad5624r_spi.c
> @@ -22,7 +22,7 @@
> #include "ad5624r.h"
>
> static int ad5624r_spi_write(struct spi_device *spi,
> - u8 cmd, u8 addr, u16 val, u8 len)
> + u8 cmd, u8 addr, u16 val, u8 shift)
> {
> u32 data;
> u8 msg[3];
> @@ -35,7 +35,7 @@ static int ad5624r_spi_write(struct spi_device *spi,
> * 14-, 12-bit input code followed by 0, 2, or 4 don't care bits,
> * for the AD5664R, AD5644R, and AD5624R, respectively.
> */
> - data = (0 << 22) | (cmd << 19) | (addr << 16) | (val << (16 - len));
> + data = (0 << 22) | (cmd << 19) | (addr << 16) | (val << shift);
> msg[0] = data >> 16;
> msg[1] = data >> 8;
> msg[2] = data;
>
next prev parent reply other threads:[~2015-06-19 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 12:48 [PATCH 1/1] iio: DAC: ad5624r_spi: fix bit shift of output data value jmfriedt
2015-06-19 12:56 ` Lars-Peter Clausen [this message]
2015-06-21 13:04 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55841173.30506@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=jmfriedt@femto-st.fr \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.