From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48448)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Z6Q1n-0005uJ-Mp
	for qemu-devel@nongnu.org; Sat, 20 Jun 2015 17:10:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Z6Q1k-0004wh-HX
	for qemu-devel@nongnu.org; Sat, 20 Jun 2015 17:10:15 -0400
Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:38569)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Z6Q1k-0004w2-Ap
	for qemu-devel@nongnu.org; Sat, 20 Jun 2015 17:10:12 -0400
Received: by wibdq8 with SMTP id dq8so44732632wib.1
	for <qemu-devel@nongnu.org>; Sat, 20 Jun 2015 14:10:11 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5585D6B0.3020803@redhat.com>
Date: Sat, 20 Jun 2015 23:10:08 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1433161230-29421-1-git-send-email-mst@redhat.com>
	<1433161230-29421-59-git-send-email-mst@redhat.com>
In-Reply-To: <1433161230-29421-59-git-send-email-mst@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL v2 58/60] qdev: add 64bit properties
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Eduardo Habkost <ehabkost@redhat.com>, Markus Armbruster <armbru@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Gerd Hoffmann <kraxel@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>



On 01/06/2015 14:25, Michael S. Tsirkin wrote:
> +static uint64_t qdev_get_prop_mask64(Property *prop)
> +{
> +    assert(prop->info == &qdev_prop_bit);
> +    return 0x1 << prop->bitnr;

This needs to be 1ull.

Paolo

> +}
> +