From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933352AbbFVLYk (ORCPT ); Mon, 22 Jun 2015 07:24:40 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:38046 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933348AbbFVLYb (ORCPT ); Mon, 22 Jun 2015 07:24:31 -0400 Message-ID: <5587F06A.1080909@redhat.com> Date: Mon, 22 Jun 2015 13:24:26 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Xiao Guangrong CC: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, dmatlack@google.com Subject: Re: [PATCH v2 11/15] KVM: MTRR: sort variable MTRRs References: <1434358535-19923-1-git-send-email-guangrong.xiao@linux.intel.com> <1434358535-19923-12-git-send-email-guangrong.xiao@linux.intel.com> <55819C27.4050404@redhat.com> In-Reply-To: <55819C27.4050404@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/06/2015 18:11, Paolo Bonzini wrote: > Also, this loop looks weird. Is this what you wanted? > > list_for_each_entry(tmp, &mtrr_state->head, node) > if (cur->base >= tmp->base) > break; > list_add_tail(&cur->node, &tmp->node); > > If so, can you look at kvm/queue and see if it is okay for you (so that > we can get the series in 4.2)? Ping? If I don't get testing results before Wednesday, I'll drop this series from the 4.2 pull request. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 11/15] KVM: MTRR: sort variable MTRRs Date: Mon, 22 Jun 2015 13:24:26 +0200 Message-ID: <5587F06A.1080909@redhat.com> References: <1434358535-19923-1-git-send-email-guangrong.xiao@linux.intel.com> <1434358535-19923-12-git-send-email-guangrong.xiao@linux.intel.com> <55819C27.4050404@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, dmatlack@google.com To: Xiao Guangrong Return-path: In-Reply-To: <55819C27.4050404@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 17/06/2015 18:11, Paolo Bonzini wrote: > Also, this loop looks weird. Is this what you wanted? > > list_for_each_entry(tmp, &mtrr_state->head, node) > if (cur->base >= tmp->base) > break; > list_add_tail(&cur->node, &tmp->node); > > If so, can you look at kvm/queue and see if it is okay for you (so that > we can get the series in 4.2)? Ping? If I don't get testing results before Wednesday, I'll drop this series from the 4.2 pull request. Paolo