From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Wahren Subject: Re: [PATCH 2/2] dt: brcm, bcm2835-aux-spi: add binding documentation for new spi-bcm2835aux Date: Mon, 22 Jun 2015 19:55:55 +0200 Message-ID: <55884C2B.8040601@lategoodbye.de> References: <1434980408-4086-1-git-send-email-kernel@martin.sperl.org> <1434980408-4086-2-git-send-email-kernel@martin.sperl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1434980408-4086-2-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Brown , Lee Jones , Stephen Warren List-Id: devicetree@vger.kernel.org Hi Martin, Am 22.06.2015 um 15:40 schrieb kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org: > From: Martin Sperl > > Signed-off-by: Martin Sperl > --- > .../bindings/spi/brcm,bcm2835-aux-spi.txt | 33 ++++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.txt > > diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.txt b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.txt > new file mode 100644 > index 0000000..23e4138 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.txt > @@ -0,0 +1,33 @@ > +Broadcom BCM2835 SPI1/2 controller > + > +The BCM2835 contains two forms of SPI master controller, one known simply as > +SPI0, and the other known as the "Universal SPI Master"; part of the > +auxiliary block. This binding applies to the SPI1/2 controller. > + > +Required properties: > +- compatible: Should be "brcm,bcm2835-aux-spi". > +- reg: Should contain register location and length for the spi block > + as well as for the common aux block control > +- interrupts: Should contain shared interrupt of the aux block > +- clocks: The clock feeding the SPI controller. > +- gpio-cs: the gpio-cs (native cs is NOT supported) do you mean "gpio-cs" or "cs-gpios" from spi/spi-bus.txt? > + > +Example: > + > +spi1@7e215080 { > + compatible = "brcm,bcm2835-aux-spi"; > + reg = <0x7e215080 0x40>, <0x7e215000 0x08>; > + interrupts = <1 29>; > + clocks = <&clk_spi>; > + #address-cells = <1>; > + #size-cells = <0>; Why is gpio-cs is missing in the examples, if it's required? > +}; > + > +spi2@7e215080 { spi2@7e2150c0 ? > + compatible = "brcm,bcm2835-aux-spi"; > + reg = <0x7e2150c0 0x40>, <0x7e215000 0x08>; > + interrupts = <1 29>; > + clocks = <&clk_spi>; > + #address-cells = <1>; > + #size-cells = <0>; > +}; > Regards Stefan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in