From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 01/15] drm/i915: Add i915_gem_object_write() to i915_gem.c Date: Thu, 25 Jun 2015 13:28:38 +0100 Message-ID: <558BF3F6.8030600@intel.com> References: <1434393394-21002-1-git-send-email-david.s.gordon@intel.com> <1434393394-21002-2-git-send-email-david.s.gordon@intel.com> <20150615200910.GE28462@nuc-i3427.alporthouse.com> <5581207C.8050305@intel.com> <20150617120211.GQ23637@phenom.ffwll.local> <5582B063.6060700@intel.com> <20150618143137.GC7752@phenom.ffwll.local> <55830DCA.40808@intel.com> <20150624093216.GY25769@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 253AC6E6F7 for ; Thu, 25 Jun 2015 05:28:40 -0700 (PDT) In-Reply-To: <20150624093216.GY25769@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gMjQvMDYvMTUgMTA6MzIsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gT24gVGh1LCBKdW4gMTgs IDIwMTUgYXQgMDc6Mjg6MjZQTSArMDEwMCwgRGF2ZSBHb3Jkb24gd3JvdGU6Cj4+IE9uIDE4LzA2 LzE1IDE1OjMxLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+Pj4gT24gVGh1LCBKdW4gMTgsIDIwMTUg YXQgMTI6NDk6NTVQTSArMDEwMCwgRGF2ZSBHb3Jkb24gd3JvdGU6Cj4+Pj4gT24gMTcvMDYvMTUg MTM6MDIsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4+Pj4+IE9uIFdlZCwgSnVuIDE3LCAyMDE1IGF0 IDA4OjIzOjQwQU0gKzAxMDAsIERhdmUgR29yZG9uIHdyb3RlOgo+Pj4+Pj4gT24gMTUvMDYvMTUg MjE6MDksIENocmlzIFdpbHNvbiB3cm90ZToKPj4+Pj4+PiBPbiBNb24sIEp1biAxNSwgMjAxNSBh dCAwNzozNjoxOVBNICswMTAwLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4+Pj4+Pj4gRnJvbTogQWxl eCBEYWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4+Pj4+Pj4+Cj4+Pj4+Pj4+IGk5MTVfZ2VtX29iamVj dF93cml0ZSgpIGlzIGEgZ2VuZXJpYyBmdW5jdGlvbiB0byBjb3B5IGRhdGEgZnJvbSBhIHBsYWlu Cj4+Pj4+Pj4+IGxpbmVhciBidWZmZXIgdG8gYSBwYWdlZCBnZW0gb2JqZWN0Lgo+Pj4+Pj4+Pgo+ Pj4+Pj4+PiBXZSB3aWxsIG5lZWQgdGhpcyBmb3IgdGhlIG1pY3JvY29udHJvbGxlciBmaXJtd2Fy ZSBsb2FkaW5nIHN1cHBvcnQgY29kZS4KPj4+Pj4+Pj4KPj4+Pj4+Pj4gSXNzdWU6IFZJWi00ODg0 Cj4+Pj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEFsZXggRGFpIDx5dS5kYWlAaW50ZWwuY29tPgo+Pj4+ Pj4+PiBTaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29t Pgo+Pj4+Pj4+PiAtLS0KPj4+Pj4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2Lmgg fCAgICAyICsrCj4+Pj4+Pj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIHwgICAy OCArKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4+Pj4+Pj4+ICAyIGZpbGVzIGNoYW5nZWQs IDMwIGluc2VydGlvbnMoKykKPj4+Pj4+Pj4KPj4+Pj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5o Cj4+Pj4+Pj4+IGluZGV4IDYxMWZiZDguLjkwOTRjMDYgMTAwNjQ0Cj4+Pj4+Pj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4+Pj4+Pj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuaAo+Pj4+Pj4+PiBAQCAtMjcxMyw2ICsyNzEzLDggQEAgdm9pZCAq aTkxNV9nZW1fb2JqZWN0X2FsbG9jKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+Pj4+Pj4+PiAg dm9pZCBpOTE1X2dlbV9vYmplY3RfZnJlZShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2Jq KTsKPj4+Pj4+Pj4gIHZvaWQgaTkxNV9nZW1fb2JqZWN0X2luaXQoc3RydWN0IGRybV9pOTE1X2dl bV9vYmplY3QgKm9iaiwKPj4+Pj4+Pj4gIAkJCSBjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29i amVjdF9vcHMgKm9wcyk7Cj4+Pj4+Pj4+ICtpbnQgaTkxNV9nZW1fb2JqZWN0X3dyaXRlKHN0cnVj dCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4+Pj4+Pj4+ICsJCQkgIGNvbnN0IHZvaWQgKmRh dGEsIHNpemVfdCBzaXplKTsKPj4+Pj4+Pj4gIHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpp OTE1X2dlbV9hbGxvY19vYmplY3Qoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPj4+Pj4+Pj4gIAkJ CQkJCSAgc2l6ZV90IHNpemUpOwo+Pj4+Pj4+PiAgdm9pZCBpOTE1X2luaXRfdm0oc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+Pj4+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMK Pj4+Pj4+Pj4gaW5kZXggYmUzNWYwNC4uNzVkNjNjMiAxMDA2NDQKPj4+Pj4+Pj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+Pj4+Pj4+PiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbS5jCj4+Pj4+Pj4+IEBAIC01MzkyLDMgKzUzOTIsMzEgQEAgYm9vbCBp OTE1X2dlbV9vYmpfaXNfcGlubmVkKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCj4+ Pj4+Pj4+ICAJcmV0dXJuIGZhbHNlOwo+Pj4+Pj4+PiAgfQo+Pj4+Pj4+PiAgCj4+Pj4+Pj4+ICsv KiBGaWxsIHRoZSBAb2JqIHdpdGggdGhlIEBzaXplIGFtb3VudCBvZiBAZGF0YSAqLwo+Pj4+Pj4+ PiAraW50IGk5MTVfZ2VtX29iamVjdF93cml0ZShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAq b2JqLAo+Pj4+Pj4+PiArCQkJY29uc3Qgdm9pZCAqZGF0YSwgc2l6ZV90IHNpemUpCj4+Pj4+Pj4+ ICt7Cj4+Pj4+Pj4+ICsJc3RydWN0IHNnX3RhYmxlICpzZzsKPj4+Pj4+Pj4gKwlzaXplX3QgYnl0 ZXM7Cj4+Pj4+Pj4+ICsJaW50IHJldDsKPj4+Pj4+Pj4gKwo+Pj4+Pj4+PiArCXJldCA9IGk5MTVf Z2VtX29iamVjdF9nZXRfcGFnZXMob2JqKTsKPj4+Pj4+Pj4gKwlpZiAocmV0KQo+Pj4+Pj4+PiAr CQlyZXR1cm4gcmV0Owo+Pj4+Pj4+PiArCj4+Pj4+Pj4+ICsJaTkxNV9nZW1fb2JqZWN0X3Bpbl9w YWdlcyhvYmopOwo+Pj4+Pj4+Cj4+Pj4+Pj4gWW91IGRvbid0IHNldCB0aGUgb2JqZWN0IGludG8g dGhlIENQVSBkb21haW4sIG9yIGluc3RlYWQgbWFudWFsbHkgaGFuZGxlCj4+Pj4+Pj4gdGhlIGRv bWFpbiBmbHVzaGluZy4gWW91IGRvbid0IGhhbmRsZSBvYmplY3RzIHRoYXQgY2Fubm90IGJlIHdy aXR0ZW4KPj4+Pj4+PiBkaXJlY3RseSBieSB0aGUgQ1BVLCBub3IgZG8geW91IGhhbmRsZSBvYmpl Y3RzIHdob3NlIHJlcHJlc2VudGF0aW9uIGluCj4+Pj4+Pj4gbWVtb3J5IGlzIG5vdCBsaW5lYXIu Cj4+Pj4+Pj4gLUNocmlzCj4+Pj4+Pgo+Pj4+Pj4gTm8gd2UgZG9uJ3QgaGFuZGxlIGp1c3QgYW55 IHJhbmRvbSBnZW0gb2JqZWN0LCBidXQgd2UgZG8gcmV0dXJuIGFuIGVycm9yCj4+Pj4+PiBjb2Rl IGZvciBhbnkgdHlwZXMgbm90IHN1cHBvcnRlZC4gSG93ZXZlciwgYXMgd2UgZG9uJ3QgcmVhbGx5 IG5lZWQgdGhlCj4+Pj4+PiBmdWxsIGdlbmVyYWxpdHkgb2Ygd3JpdGluZyBpbnRvIGEgZ2VtIG9i amVjdCBvZiBhbnkgdHlwZSwgSSB3aWxsIHJlcGxhY2UKPj4+Pj4+IHRoaXMgZnVuY3Rpb24gd2l0 aCBvbmUgdGhhdCBjb21iaW5lcyB0aGUgYWxsb2NhdGlvbiBvZiBhIG5ldyBvYmplY3QKPj4+Pj4+ ICh3aGljaCB3aWxsIHRoZXJlZm9yZSBkZWZpbml0ZWx5IGJlIG9mIHRoZSBjb3JyZWN0IHR5cGUs IGluIHRoZSBjb3JyZWN0Cj4+Pj4+PiBkb21haW4sIGV0YykgYW5kIGZpbGxpbmcgaXQgd2l0aCB0 aGUgZGF0YSB0byBiZSBwcmVzZXJ2ZWQuCj4+Pj4KPj4+PiBUaGUgdXNhZ2UgcGF0dGVybiBmb3Ig dGhlIHBhcnRpY3VsYXIgY2FzZSBpcyBnb2luZyB0byBiZToKPj4+PiAJT25jZS1vbmx5Ogo+Pj4+ IAkJQWxsb2NhdGUKPj4+PiAJCUZpbGwKPj4+PiAJVGhlbiBlYWNoIHRpbWUgR3VDIGlzIChyZS0p aW5pdGlhbGlzZWQ6Cj4+Pj4gCQlNYXAgdG8gR1RUCj4+Pj4gCQlETUEtcmVhZCBmcm9tIGJ1ZmZl ciBpbnRvIEd1QyBwcml2YXRlIG1lbW9yeQo+Pj4+IAkJVW5tYXAKPj4+PiAJT25seSBvbiB1bmxv YWQ6Cj4+Pj4gCQlEaXNwb3NlCj4+Pj4KPj4+PiBTbyBvdXIgb2JqZWN0IGlzIHdyaXRlLW9uY2Ug YnkgdGhlIENQVSAoYW5kIHRoYXQncyBhbHdheXMgdGhlIGZpcnN0Cj4+Pj4gb3BlcmF0aW9uKSwg dGhlcmVhZnRlciByZWFkLW9jY2FzaW9uYWxseSBieSB0aGUgR3VDJ3MgRE1BIGVuZ2luZS4KPj4+ Cj4+PiBZdXAuIFRoZSBwcm9ibGVtIGlzIG1vcmUgdGhhdCBvbiBhdG9tIHBsYXRmb3JtcyB0aGUg b2JqZWN0cyBhcmVuJ3QKPj4+IGNvaGVyZW50IGJ5IGRlZmF1bHQgYW5kIGdlbmVyYWxseSB5b3Ug bmVlZCB0byBkbyBzb21ldGhpbmcuIEhlbmNlIHdlCj4+PiBlaXRoZXIgaGF2ZQo+Pj4gLSBhbiBl eHBsaWNpdCBzZXRfY2FjaGluZyBjYWxsIHRvIGRvY3VtZW50IHRoYXQgdGhpcyBpcyBhIGdwdSBv YmplY3Qgd2hpY2gKPj4+ICAgaXMgYWx3YXlzIGNvaGVyZW50IChzbyBhbHNvIG9uIGNodi9ieHQp LCBldmVuIHdoZW4gdGhhdCdzIGEgbm8tb3Agb24gYmlnCj4+PiAgIGNvcmUKPj4+IC0gb3Igd3Jh cCBldmVyeXRoaW5nIGluIHNldF9kb21haW4gY2FsbHMsIGV2ZW4gd2hlbiB0aG9zZSBhcmUgbm8t b3BzIHRvby4KPj4+Cj4+PiBJZiBlaXRoZXIgb2YgdGhvc2UgbGFjaywgcmV2aWV3cyB0ZW5kIHRv IGZyZWFrIG91dCBwcmVlbXB0aXZlbHkgYW5kIHRoZQo+Pj4gcmVwdGlsIGJyYWluIHRha2VzIG92 ZXIgOy0pCj4+Pgo+Pj4gQ2hlZXJzLCBEYW5pZWwKPj4KPj4gV2UgZG9uJ3QgbmVlZCAiY29oZXJl bmN5IiBhcyBzdWNoLiBUaGUgYnVmZmVyIGlzIGZpbGxlZCAob25jZSBvbmx5KSBieQo+PiB0aGUg Q1BVIChzbyBJIHNob3VsZCBwdXQgYSBzZXQtdG8tY3B1LWRvbWFpbiBiZXR3ZWVuIHRoZSBhbGxv Y2F0ZSBhbmQKPj4gZmlsbCBzdGFnZXM/KSBPbmNlIGl0J3MgZmlsbGVkLCB0aGUgQ1BVIG5lZWQg bm90IHJlYWQgb3Igd3JpdGUgaXQgZXZlcgo+PiBhZ2Fpbi4KPj4KPj4gVGhlbiBiZWZvcmUgdGhl IERNQSBlbmdpbmUgYWNjZXNzZXMgaXQsIHdlIGNhbGwgaTkxNV9nZW1fb2JqX2dndHRfcGluLAo+ PiB3aGljaCBJJ20gYXNzdW1pbmcgd2lsbCB0YWtlIGNhcmUgb2YgYW55IGNvaGVyZW5jeSBpc3N1 ZXMgKG1ha2luZyBzdXJlCj4+IHRoZSBkYXRhIHdyaXR0ZW4gYnkgdGhlIENQVSBpcyBub3cgdmlz aWJsZSB0byB0aGUgRE1BIGVuZ2luZSkgd2hlbiBpdAo+PiBwdXRzIHRoZSBidWZmZXIgaW50byB0 aGUgR1RULXJlYWRhYmxlIGRvbWFpbi4gSXMgdGhhdCBub3Qgc3VmZmljaWVudD8KPiAKPiBQaW5u aW5nIGlzIG9ydGhvZ29uYWwgdG8gY29oZXJlbmN5LCBpdCdsbCBqdXN0IG1ha2Ugc3VyZSB0aGUg YmFja2luZwo+IHN0b3JhZ2UgaXMgdGhlcmUuIHNldF9kb21haW4oQ1BVKSBiZWZvcmUgd3JpdGlu ZyBhbmQgc2V0X2RvbWFpbihHVFQpCj4gYmVmb3JlIGVhY2ggdXBsb2FkIHRvIHRoZSBndWMgdXNp bmcgdGhlIGh3IGNvcHkgdGhpbmcgd291bGQgYmUgcHJ1ZGVudC4KPiBUaGUgY29oZXJlbmN5IHRy YWNraW5nIHNob3VsZCBuby1vcCBvdXQgYW55IGNhbGxzIHdoaWNoIGFyZW4ndCBuZWVkZWQgZm9y Cj4geW91Lgo+IC1EYW5pZWwKCk9LLCBkb25lOyBJIGhhZCBhbHJlYWR5IGFkZGVkIHNldF9kb21h aW4oQ1BVKSBpbiB0aGUgYWxsb2NhdGUtYW5kLWZpbGwKY29kZSwgbm93IEkndmUganVzdCBhZGRl ZCBpOTE1X2dlbV9vYmplY3Rfc2V0X3RvX2d0dF9kb21haW4ob2JqLCBmYWxzZSkKaW4gdGhlIGRt YS10by1oL3cgY29kZS4KCi5EYXZlLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=