From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752737AbbF3JUs (ORCPT ); Tue, 30 Jun 2015 05:20:48 -0400 Received: from mail-wg0-f51.google.com ([74.125.82.51]:32930 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751909AbbF3JUj (ORCPT ); Tue, 30 Jun 2015 05:20:39 -0400 Message-ID: <55925F6B.1010006@linaro.org> Date: Tue, 30 Jun 2015 11:20:43 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Viresh Kumar CC: Thomas Gleixner , linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Oleksij Rempel Subject: Re: [PATCH 01/41] clocksource: asm9260: Migrate to new 'set-state' interface References: <57ae9434bbb7218961c3ad45a26fbe1fffe40cbd.1434622147.git.viresh.kumar@linaro.org> <55925268.4050109@linaro.org> <20150630090048.GA4626@linux> In-Reply-To: <20150630090048.GA4626@linux> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/30/2015 11:00 AM, Viresh Kumar wrote: > On 30-06-15, 10:25, Daniel Lezcano wrote: >> Could you add in the changelog the subtle change with >> set_mode(RESUME) and this code. As a default the timer was stopped >> when entering in the set_mode function, now with the new API, this >> is done explicitly. > >> Can you replace this line with a call to asm9260_timer_shutdown ? > > How does this look ? Looks good to me. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Tue, 30 Jun 2015 11:20:43 +0200 Subject: [PATCH 01/41] clocksource: asm9260: Migrate to new 'set-state' interface In-Reply-To: <20150630090048.GA4626@linux> References: <57ae9434bbb7218961c3ad45a26fbe1fffe40cbd.1434622147.git.viresh.kumar@linaro.org> <55925268.4050109@linaro.org> <20150630090048.GA4626@linux> Message-ID: <55925F6B.1010006@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/30/2015 11:00 AM, Viresh Kumar wrote: > On 30-06-15, 10:25, Daniel Lezcano wrote: >> Could you add in the changelog the subtle change with >> set_mode(RESUME) and this code. As a default the timer was stopped >> when entering in the set_mode function, now with the new API, this >> is done explicitly. > >> Can you replace this line with a call to asm9260_timer_shutdown ? > > How does this look ? Looks good to me. -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog