From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48214)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1ZA6LH-0005O0-35
	for qemu-devel@nongnu.org; Tue, 30 Jun 2015 20:57:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1ZA6LD-000203-UD
	for qemu-devel@nongnu.org; Tue, 30 Jun 2015 20:57:35 -0400
Message-ID: <55933BDC.40401@cn.fujitsu.com>
Date: Wed, 1 Jul 2015 09:01:16 +0800
From: Wen Congyang <wency@cn.fujitsu.com>
MIME-Version: 1.0
References: <20150618125533.GE25387@stefanha-thinkpad.redhat.com>
	<5582D777.8060202@gmail.com>
	<20150618160618.GF822@stefanha-thinkpad.redhat.com>
	<55836860.2010401@cn.fujitsu.com>
	<20150619104953.GB9807@stefanha-thinkpad.redhat.com>
	<5584DEA8.80005@gmail.com> <20150624140755.GC2206@work-vm>
	<558B52EE.3000800@cn.fujitsu.com> <20150626190335.GN2186@work-vm>
	<559099E5.6080205@cn.fujitsu.com> <20150630190146.GE2142@work-vm>
In-Reply-To: <20150630190146.GE2142@work-vm>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new
 block driver interface to connect/disconnect the remote target
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Wen Congyang <ghostwcy@gmail.com>, qemu block <qemu-block@nongnu.org>, Stefan Hajnoczi <stefanha@gmail.com>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, qemu devel <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>, Lai Jiangshan <laijs@cn.fujitsu.com>, Gonglei <arei.gonglei@huawei.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>

On 07/01/2015 03:01 AM, Dr. David Alan Gilbert wrote:
> * Wen Congyang (wency@cn.fujitsu.com) wrote:
>> On 06/27/2015 03:03 AM, Dr. David Alan Gilbert wrote:
> 
> <snip>
> 
>>> Ah, I hadn't realised you could do that; so do you just do:
>>>
>>> migrate_set_parameter colo on
>>> migrate -d -b tcp:otherhhost:port
>>>
>>> How does the secondary know to feed that data straight into the disk without
>>> recording all the old data into the hidden-disk ?
>>
>> hidden disk and active disk will be made empty when starting block replication.
> 
> Hmm, yes - I think I need to update to your current world; in the version
> from the end of May, I get a 'error while loading state for instance 0x0 of device 'block''
> if I try to use migrate -d -b 
> (the bdrv_write fails)

Can you give me both primary and secondary qemu's command? I think the command line is wrong,
and disk migration fails.

> 
>>>> If the user uses mirror job, we don't cancel the mirror job now.
>>>
>>> It would be good to get it to work with mirror, that seems preferred these
>>> days to the old block migration.
>>
>> In normal migration, is mirror job created and cancelled by libvirt?
> 
> Yes, I think so; you should be able to turn on full logging on libvirt and
> watch the qmp commands it sends.

Supporting mirror job in my TODO list now. But I think we should focus the basci function now.

Thanks
Wen Congyang

> 
> Dave
> 
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> .
>