From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754185AbbGBTll (ORCPT ); Thu, 2 Jul 2015 15:41:41 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:38194 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753804AbbGBTld (ORCPT ); Thu, 2 Jul 2015 15:41:33 -0400 Message-ID: <559593F3.5030802@linaro.org> Date: Thu, 02 Jul 2015 21:41:39 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Viresh Kumar , Thomas Gleixner CC: linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thierry Reding , Stephen Warren Subject: Re: [PATCH 25/41] clocksource: tegra20: Migrate to new 'set-state' interface References: <1888421925acbfbcc453488d254faa154cd0fc2b.1434622147.git.viresh.kumar@linaro.org> In-Reply-To: <1888421925acbfbcc453488d254faa154cd0fc2b.1434622147.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/18/2015 12:54 PM, Viresh Kumar wrote: > Migrate tegra20 driver to the new 'set-state' interface provided by > clockevents core, the earlier 'set-mode' interface is marked obsolete > now. > > This also enables us to implement callbacks for new states of clockevent > devices, for example: ONESHOT_STOPPED. > > Cc: Thierry Reding > Cc: Stephen Warren > Signed-off-by: Viresh Kumar > --- [ ... ] > +static int tegra_timer_shutdown(struct clock_event_device *evt) > { > - u32 reg; > - > timer_writel(0, TIMER3_BASE + TIMER_PTV); > + return 0; > +} > > - switch (mode) { > - case CLOCK_EVT_MODE_PERIODIC: > - reg = 0xC0000000 | ((1000000/HZ)-1); > - timer_writel(reg, TIMER3_BASE + TIMER_PTV); > - break; > - case CLOCK_EVT_MODE_ONESHOT: > - break; > - case CLOCK_EVT_MODE_UNUSED: > - case CLOCK_EVT_MODE_SHUTDOWN: > - case CLOCK_EVT_MODE_RESUME: > - break; > - } > +static int tegra_timer_set_periodic(struct clock_event_device *evt) > +{ > + u32 reg = 0xC0000000 | ((1000000 / HZ) - 1); > + > + timer_writel(0, TIMER3_BASE + TIMER_PTV); Replace with 'tegra_timer_shutdown' > + timer_writel(reg, TIMER3_BASE + TIMER_PTV); > + return 0; > } -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Thu, 02 Jul 2015 21:41:39 +0200 Subject: [PATCH 25/41] clocksource: tegra20: Migrate to new 'set-state' interface In-Reply-To: <1888421925acbfbcc453488d254faa154cd0fc2b.1434622147.git.viresh.kumar@linaro.org> References: <1888421925acbfbcc453488d254faa154cd0fc2b.1434622147.git.viresh.kumar@linaro.org> Message-ID: <559593F3.5030802@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/18/2015 12:54 PM, Viresh Kumar wrote: > Migrate tegra20 driver to the new 'set-state' interface provided by > clockevents core, the earlier 'set-mode' interface is marked obsolete > now. > > This also enables us to implement callbacks for new states of clockevent > devices, for example: ONESHOT_STOPPED. > > Cc: Thierry Reding > Cc: Stephen Warren > Signed-off-by: Viresh Kumar > --- [ ... ] > +static int tegra_timer_shutdown(struct clock_event_device *evt) > { > - u32 reg; > - > timer_writel(0, TIMER3_BASE + TIMER_PTV); > + return 0; > +} > > - switch (mode) { > - case CLOCK_EVT_MODE_PERIODIC: > - reg = 0xC0000000 | ((1000000/HZ)-1); > - timer_writel(reg, TIMER3_BASE + TIMER_PTV); > - break; > - case CLOCK_EVT_MODE_ONESHOT: > - break; > - case CLOCK_EVT_MODE_UNUSED: > - case CLOCK_EVT_MODE_SHUTDOWN: > - case CLOCK_EVT_MODE_RESUME: > - break; > - } > +static int tegra_timer_set_periodic(struct clock_event_device *evt) > +{ > + u32 reg = 0xC0000000 | ((1000000 / HZ) - 1); > + > + timer_writel(0, TIMER3_BASE + TIMER_PTV); Replace with 'tegra_timer_shutdown' > + timer_writel(reg, TIMER3_BASE + TIMER_PTV); > + return 0; > } -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog