From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754124AbbGBUMA (ORCPT ); Thu, 2 Jul 2015 16:12:00 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:34323 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753930AbbGBULx (ORCPT ); Thu, 2 Jul 2015 16:11:53 -0400 Message-ID: <55959B0F.5000306@linaro.org> Date: Thu, 02 Jul 2015 22:11:59 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Viresh Kumar , Thomas Gleixner CC: linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Tang Subject: Re: [PATCH 41/41] clocksource: zevio: Migrate to new 'set-state' interface References: <2492473d6bb8f057af389d6db24af77462af2468.1434622147.git.viresh.kumar@linaro.org> In-Reply-To: <2492473d6bb8f057af389d6db24af77462af2468.1434622147.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/18/2015 12:54 PM, Viresh Kumar wrote: > Migrate zevio driver to the new 'set-state' interface provided by > clockevents core, the earlier 'set-mode' interface is marked obsolete > now. > > This also enables us to implement callbacks for new states of clockevent > devices, for example: ONESHOT_STOPPED. > > Cc: Daniel Tang > Signed-off-by: Viresh Kumar > --- [ ... ] > static irqreturn_t zevio_timer_interrupt(int irq, void *dev_id) > @@ -162,7 +158,9 @@ static int __init zevio_timer_add(struct device_node *node) > if (timer->interrupt_regs && irqnr) { > timer->clkevt.name = timer->clockevent_name; > timer->clkevt.set_next_event = zevio_timer_set_event; > - timer->clkevt.set_mode = zevio_timer_set_mode; > + timer->clkevt.set_state_shutdown = zevio_timer_shutdown; > + timer->clkevt.set_state_oneshot = zevio_timer_set_oneshot; > + timer->clkevt.tick_resume = zevio_timer_set_oneshot; Why is tick_resume added here ? > timer->clkevt.rating = 200; > timer->clkevt.cpumask = cpu_all_mask; > timer->clkevt.features = CLOCK_EVT_FEAT_ONESHOT; > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Thu, 02 Jul 2015 22:11:59 +0200 Subject: [PATCH 41/41] clocksource: zevio: Migrate to new 'set-state' interface In-Reply-To: <2492473d6bb8f057af389d6db24af77462af2468.1434622147.git.viresh.kumar@linaro.org> References: <2492473d6bb8f057af389d6db24af77462af2468.1434622147.git.viresh.kumar@linaro.org> Message-ID: <55959B0F.5000306@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/18/2015 12:54 PM, Viresh Kumar wrote: > Migrate zevio driver to the new 'set-state' interface provided by > clockevents core, the earlier 'set-mode' interface is marked obsolete > now. > > This also enables us to implement callbacks for new states of clockevent > devices, for example: ONESHOT_STOPPED. > > Cc: Daniel Tang > Signed-off-by: Viresh Kumar > --- [ ... ] > static irqreturn_t zevio_timer_interrupt(int irq, void *dev_id) > @@ -162,7 +158,9 @@ static int __init zevio_timer_add(struct device_node *node) > if (timer->interrupt_regs && irqnr) { > timer->clkevt.name = timer->clockevent_name; > timer->clkevt.set_next_event = zevio_timer_set_event; > - timer->clkevt.set_mode = zevio_timer_set_mode; > + timer->clkevt.set_state_shutdown = zevio_timer_shutdown; > + timer->clkevt.set_state_oneshot = zevio_timer_set_oneshot; > + timer->clkevt.tick_resume = zevio_timer_set_oneshot; Why is tick_resume added here ? > timer->clkevt.rating = 200; > timer->clkevt.cpumask = cpu_all_mask; > timer->clkevt.features = CLOCK_EVT_FEAT_ONESHOT; > -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog