From mboxrd@z Thu Jan 1 00:00:00 1970 From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath) Date: Fri, 03 Jul 2015 23:43:18 +0530 Subject: [PATCH-V2 04/12] i2c: pxa: Reset i2c controller on timeout in interrupt and pio mode In-Reply-To: <87fv55clcy.fsf@belgarion.home> References: <1434383399-2370-1-git-send-email-vaibhav.hiremath@linaro.org> <1434383399-2370-5-git-send-email-vaibhav.hiremath@linaro.org> <87fv55clcy.fsf@belgarion.home> Message-ID: <5596D0BE.8070902@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 03 July 2015 08:57 PM, Robert Jarzmik wrote: > Vaibhav Hiremath writes: > >> In case of timeout during msg xfer assert reset to >> i2c controller for both interrupt and PIO mode of operation. >> >> Signed-off-by: Jett.Zhou >> [vaibhav.hiremath at linaro.org: Split & merge patches into logical changes >> and update the Changelog] >> Signed-off-by: Vaibhav Hiremath > > I already said it previously, I'm against an unconditional reset in a timeout > path. Make it a quirk or whatever, but in the current status, I'm against. > > The previous behavior looks correct to me : upon timeout, retry, no need to > reset. > We still do return RETRY here, but also assert reset to I2C. Anyway, lets revisit this again later. I will remove it in my next version. Thanks, Vaibhav From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vaibhav Hiremath Subject: Re: [PATCH-V2 04/12] i2c: pxa: Reset i2c controller on timeout in interrupt and pio mode Date: Fri, 03 Jul 2015 23:43:18 +0530 Message-ID: <5596D0BE.8070902@linaro.org> References: <1434383399-2370-1-git-send-email-vaibhav.hiremath@linaro.org> <1434383399-2370-5-git-send-email-vaibhav.hiremath@linaro.org> <87fv55clcy.fsf@belgarion.home> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87fv55clcy.fsf-4ty26DBLk+jEm7gnYqmdkQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Robert Jarzmik Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org, "Jett.Zhou" List-Id: linux-i2c@vger.kernel.org On Friday 03 July 2015 08:57 PM, Robert Jarzmik wrote: > Vaibhav Hiremath writes: > >> In case of timeout during msg xfer assert reset to >> i2c controller for both interrupt and PIO mode of operation. >> >> Signed-off-by: Jett.Zhou >> [vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org: Split & merge patches into logical changes >> and update the Changelog] >> Signed-off-by: Vaibhav Hiremath > > I already said it previously, I'm against an unconditional reset in a timeout > path. Make it a quirk or whatever, but in the current status, I'm against. > > The previous behavior looks correct to me : upon timeout, retry, no need to > reset. > We still do return RETRY here, but also assert reset to I2C. Anyway, lets revisit this again later. I will remove it in my next version. Thanks, Vaibhav