From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754197AbbGGGhd (ORCPT ); Tue, 7 Jul 2015 02:37:33 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:33513 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751885AbbGGGhX (ORCPT ); Tue, 7 Jul 2015 02:37:23 -0400 Message-ID: <559B739A.3080300@linaro.org> Date: Tue, 07 Jul 2015 12:07:14 +0530 From: Vaibhav Hiremath User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Alexandre Belloni CC: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, lee.jones@linaro.org, devicetree@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Chao Xie Subject: Re: [rtc-linux] [PATCH-v2] rtc: 88pm80x: add device tree support References: <1434567488-6477-1-git-send-email-vaibhav.hiremath@linaro.org> <1434567488-6477-3-git-send-email-vaibhav.hiremath@linaro.org> <20150620004354.GY27492@piout.net> <558BB1C1.2090400@linaro.org> In-Reply-To: <558BB1C1.2090400@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 25 June 2015 01:16 PM, Vaibhav Hiremath wrote: > > > On Saturday 20 June 2015 06:13 AM, Alexandre Belloni wrote: >> Hi, >> > > Sorry I missed this email. > Just wanted to send reminder email and saw this :) > >> On 18/06/2015 at 00:28:06 +0530, Vaibhav Hiremath wrote : >>> - pdata = dev_get_platdata(&pdev->dev); >>> - if (pdata == NULL) >>> - dev_warn(&pdev->dev, "No platform data!\n"); >>> + if (!pdata && !node) { >>> + dev_err(&pdev->dev, >>> + "pm80x-rtc requires platform data or of_node\n"); >>> + return -EINVAL; >>> + } >>> + >>> + if (!pdata) { >>> + pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); >> >> I had troubles to follow the rtc_wakeup initialization cleanup but it >> seems OK. > > Probably, once we have complete PM support ready then it would be > easier to understand. I think as of now lets have this minimal code for > rtc_wakeup. > >> However, I'm wondering why you are adding DT support as this >> will always be probed from the MFD driver which pass the platform_data >> and avoids that allocation. >> > > You are right. > > Originally, it was cleanup patch, > > - remove pm80x_pdata > - Add check for pdata and np > - and around rtc_wakeup > > While doing that I added this nice to have allocation. > Any update/feedback on this? Thanks, Vaibhav From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vaibhav Hiremath Subject: Re: [rtc-linux] [PATCH-v2] rtc: 88pm80x: add device tree support Date: Tue, 07 Jul 2015 12:07:14 +0530 Message-ID: <559B739A.3080300@linaro.org> References: <1434567488-6477-1-git-send-email-vaibhav.hiremath@linaro.org> <1434567488-6477-3-git-send-email-vaibhav.hiremath@linaro.org> <20150620004354.GY27492@piout.net> <558BB1C1.2090400@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <558BB1C1.2090400-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexandre Belloni Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Chao Xie List-Id: devicetree@vger.kernel.org On Thursday 25 June 2015 01:16 PM, Vaibhav Hiremath wrote: > > > On Saturday 20 June 2015 06:13 AM, Alexandre Belloni wrote: >> Hi, >> > > Sorry I missed this email. > Just wanted to send reminder email and saw this :) > >> On 18/06/2015 at 00:28:06 +0530, Vaibhav Hiremath wrote : >>> - pdata = dev_get_platdata(&pdev->dev); >>> - if (pdata == NULL) >>> - dev_warn(&pdev->dev, "No platform data!\n"); >>> + if (!pdata && !node) { >>> + dev_err(&pdev->dev, >>> + "pm80x-rtc requires platform data or of_node\n"); >>> + return -EINVAL; >>> + } >>> + >>> + if (!pdata) { >>> + pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); >> >> I had troubles to follow the rtc_wakeup initialization cleanup but it >> seems OK. > > Probably, once we have complete PM support ready then it would be > easier to understand. I think as of now lets have this minimal code for > rtc_wakeup. > >> However, I'm wondering why you are adding DT support as this >> will always be probed from the MFD driver which pass the platform_data >> and avoids that allocation. >> > > You are right. > > Originally, it was cleanup patch, > > - remove pm80x_pdata > - Add check for pdata and np > - and around rtc_wakeup > > While doing that I added this nice to have allocation. > Any update/feedback on this? Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f181.google.com (mail-pd0-f181.google.com. [209.85.192.181]) by gmr-mx.google.com with ESMTPS id xz5si2142784pac.1.2015.07.06.23.37.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Jul 2015 23:37:23 -0700 (PDT) Received: by pddu5 with SMTP id u5so32510231pdd.3 for ; Mon, 06 Jul 2015 23:37:23 -0700 (PDT) Message-ID: <559B739A.3080300@linaro.org> Date: Tue, 07 Jul 2015 12:07:14 +0530 From: Vaibhav Hiremath MIME-Version: 1.0 To: Alexandre Belloni CC: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, lee.jones@linaro.org, devicetree@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Chao Xie Subject: Re: [rtc-linux] [PATCH-v2] rtc: 88pm80x: add device tree support References: <1434567488-6477-1-git-send-email-vaibhav.hiremath@linaro.org> <1434567488-6477-3-git-send-email-vaibhav.hiremath@linaro.org> <20150620004354.GY27492@piout.net> <558BB1C1.2090400@linaro.org> In-Reply-To: <558BB1C1.2090400@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Thursday 25 June 2015 01:16 PM, Vaibhav Hiremath wrote: > > > On Saturday 20 June 2015 06:13 AM, Alexandre Belloni wrote: >> Hi, >> > > Sorry I missed this email. > Just wanted to send reminder email and saw this :) > >> On 18/06/2015 at 00:28:06 +0530, Vaibhav Hiremath wrote : >>> - pdata = dev_get_platdata(&pdev->dev); >>> - if (pdata == NULL) >>> - dev_warn(&pdev->dev, "No platform data!\n"); >>> + if (!pdata && !node) { >>> + dev_err(&pdev->dev, >>> + "pm80x-rtc requires platform data or of_node\n"); >>> + return -EINVAL; >>> + } >>> + >>> + if (!pdata) { >>> + pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); >> >> I had troubles to follow the rtc_wakeup initialization cleanup but it >> seems OK. > > Probably, once we have complete PM support ready then it would be > easier to understand. I think as of now lets have this minimal code for > rtc_wakeup. > >> However, I'm wondering why you are adding DT support as this >> will always be probed from the MFD driver which pass the platform_data >> and avoids that allocation. >> > > You are right. > > Originally, it was cleanup patch, > > - remove pm80x_pdata > - Add check for pdata and np > - and around rtc_wakeup > > While doing that I added this nice to have allocation. > Any update/feedback on this? Thanks, Vaibhav -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath) Date: Tue, 07 Jul 2015 12:07:14 +0530 Subject: [rtc-linux] [PATCH-v2] rtc: 88pm80x: add device tree support In-Reply-To: <558BB1C1.2090400@linaro.org> References: <1434567488-6477-1-git-send-email-vaibhav.hiremath@linaro.org> <1434567488-6477-3-git-send-email-vaibhav.hiremath@linaro.org> <20150620004354.GY27492@piout.net> <558BB1C1.2090400@linaro.org> Message-ID: <559B739A.3080300@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 25 June 2015 01:16 PM, Vaibhav Hiremath wrote: > > > On Saturday 20 June 2015 06:13 AM, Alexandre Belloni wrote: >> Hi, >> > > Sorry I missed this email. > Just wanted to send reminder email and saw this :) > >> On 18/06/2015 at 00:28:06 +0530, Vaibhav Hiremath wrote : >>> - pdata = dev_get_platdata(&pdev->dev); >>> - if (pdata == NULL) >>> - dev_warn(&pdev->dev, "No platform data!\n"); >>> + if (!pdata && !node) { >>> + dev_err(&pdev->dev, >>> + "pm80x-rtc requires platform data or of_node\n"); >>> + return -EINVAL; >>> + } >>> + >>> + if (!pdata) { >>> + pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); >> >> I had troubles to follow the rtc_wakeup initialization cleanup but it >> seems OK. > > Probably, once we have complete PM support ready then it would be > easier to understand. I think as of now lets have this minimal code for > rtc_wakeup. > >> However, I'm wondering why you are adding DT support as this >> will always be probed from the MFD driver which pass the platform_data >> and avoids that allocation. >> > > You are right. > > Originally, it was cleanup patch, > > - remove pm80x_pdata > - Add check for pdata and np > - and around rtc_wakeup > > While doing that I added this nice to have allocation. > Any update/feedback on this? Thanks, Vaibhav