From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754069AbbGJIb4 (ORCPT ); Fri, 10 Jul 2015 04:31:56 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:45015 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753416AbbGJIbu (ORCPT ); Fri, 10 Jul 2015 04:31:50 -0400 Message-ID: <559F82C7.5010202@ti.com> Date: Fri, 10 Jul 2015 11:31:03 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Chunfeng Yun , Mathias Nyman CC: Rob Herring , Mark Rutland , Matthias Brugger , Felipe Balbi , Sascha Hauer , , , , , Subject: Re: [PATCH v2 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller References: <1436348468-4126-1-git-send-email-chunfeng.yun@mediatek.com> <1436348468-4126-3-git-send-email-chunfeng.yun@mediatek.com> In-Reply-To: <1436348468-4126-3-git-send-email-chunfeng.yun@mediatek.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 08/07/15 12:41, Chunfeng Yun wrote: > add a DT binding documentation of xHCI host controller for the > MT8173 SoC from Mediatek. > > Signed-off-by: Chunfeng Yun > --- > .../devicetree/bindings/usb/mt8173-xhci.txt | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/mt8173-xhci.txt > > diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > new file mode 100644 > index 0000000..94cec94 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > @@ -0,0 +1,27 @@ > +MT65XX xhci > + > +The device node for Mediatek SOC usb3.0 host controller > + > +Required properties: > + - compatible : supports "mediatek,mt8173-xhci" > + - reg : Offset and length of registers > + - interrupts : Interrupt mode, number and trigger mode > + - reg-vusb33-supply: regulator of usb avdd3.3v > + - reg-vbus-supply : regulator of vbus; General trend is to use -supply. We already know it is a regulator so no need to add "reg-" So those two can be vusb33-supply: vbus-supply: > + - usb-phy : the phy that xhci will bind > + - usb3-lpm-capable: supports USB3 LPM > + - clocks : must support all clocks that xhci needs > + - clock-names: should be "sys_mac" for sys and mac clocks > + > +Example: > +usb: usb30@11270000 { > + compatible = "mediatek,mt8173-xhci"; > + reg = <0 0x11270000 0 0x1000>; > + interrupts = ; > + reg-vusb33-supply = <&mt6397_vusb_reg>; > + reg-vbus-supply = <&usb_p1_vbus>; > + usb-phy = <&u3phy>; > + usb3-lpm-capable; > + clocks = <&topckgen CLK_TOP_USB30_SEL>; > + clock-names = "sys_mac"; > +}; > cheers, -roger From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Subject: Re: [PATCH v2 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller Date: Fri, 10 Jul 2015 11:31:03 +0300 Message-ID: <559F82C7.5010202@ti.com> References: <1436348468-4126-1-git-send-email-chunfeng.yun@mediatek.com> <1436348468-4126-3-git-send-email-chunfeng.yun@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1436348468-4126-3-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Chunfeng Yun , Mathias Nyman Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sascha Hauer , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Felipe Balbi , Rob Herring , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Matthias Brugger , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mediatek@lists.infradead.org Hi, On 08/07/15 12:41, Chunfeng Yun wrote: > add a DT binding documentation of xHCI host controller for the > MT8173 SoC from Mediatek. > > Signed-off-by: Chunfeng Yun > --- > .../devicetree/bindings/usb/mt8173-xhci.txt | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/mt8173-xhci.txt > > diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > new file mode 100644 > index 0000000..94cec94 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > @@ -0,0 +1,27 @@ > +MT65XX xhci > + > +The device node for Mediatek SOC usb3.0 host controller > + > +Required properties: > + - compatible : supports "mediatek,mt8173-xhci" > + - reg : Offset and length of registers > + - interrupts : Interrupt mode, number and trigger mode > + - reg-vusb33-supply: regulator of usb avdd3.3v > + - reg-vbus-supply : regulator of vbus; General trend is to use -supply. We already know it is a regulator so no need to add "reg-" So those two can be vusb33-supply: vbus-supply: > + - usb-phy : the phy that xhci will bind > + - usb3-lpm-capable: supports USB3 LPM > + - clocks : must support all clocks that xhci needs > + - clock-names: should be "sys_mac" for sys and mac clocks > + > +Example: > +usb: usb30@11270000 { > + compatible = "mediatek,mt8173-xhci"; > + reg = <0 0x11270000 0 0x1000>; > + interrupts = ; > + reg-vusb33-supply = <&mt6397_vusb_reg>; > + reg-vbus-supply = <&usb_p1_vbus>; > + usb-phy = <&u3phy>; > + usb3-lpm-capable; > + clocks = <&topckgen CLK_TOP_USB30_SEL>; > + clock-names = "sys_mac"; > +}; > cheers, -roger From mboxrd@z Thu Jan 1 00:00:00 1970 From: rogerq@ti.com (Roger Quadros) Date: Fri, 10 Jul 2015 11:31:03 +0300 Subject: [PATCH v2 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller In-Reply-To: <1436348468-4126-3-git-send-email-chunfeng.yun@mediatek.com> References: <1436348468-4126-1-git-send-email-chunfeng.yun@mediatek.com> <1436348468-4126-3-git-send-email-chunfeng.yun@mediatek.com> Message-ID: <559F82C7.5010202@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 08/07/15 12:41, Chunfeng Yun wrote: > add a DT binding documentation of xHCI host controller for the > MT8173 SoC from Mediatek. > > Signed-off-by: Chunfeng Yun > --- > .../devicetree/bindings/usb/mt8173-xhci.txt | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/mt8173-xhci.txt > > diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > new file mode 100644 > index 0000000..94cec94 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > @@ -0,0 +1,27 @@ > +MT65XX xhci > + > +The device node for Mediatek SOC usb3.0 host controller > + > +Required properties: > + - compatible : supports "mediatek,mt8173-xhci" > + - reg : Offset and length of registers > + - interrupts : Interrupt mode, number and trigger mode > + - reg-vusb33-supply: regulator of usb avdd3.3v > + - reg-vbus-supply : regulator of vbus; General trend is to use -supply. We already know it is a regulator so no need to add "reg-" So those two can be vusb33-supply: vbus-supply: > + - usb-phy : the phy that xhci will bind > + - usb3-lpm-capable: supports USB3 LPM > + - clocks : must support all clocks that xhci needs > + - clock-names: should be "sys_mac" for sys and mac clocks > + > +Example: > +usb: usb30 at 11270000 { > + compatible = "mediatek,mt8173-xhci"; > + reg = <0 0x11270000 0 0x1000>; > + interrupts = ; > + reg-vusb33-supply = <&mt6397_vusb_reg>; > + reg-vbus-supply = <&usb_p1_vbus>; > + usb-phy = <&u3phy>; > + usb3-lpm-capable; > + clocks = <&topckgen CLK_TOP_USB30_SEL>; > + clock-names = "sys_mac"; > +}; > cheers, -roger