From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v3 17/28] tools/libxl: Infrastructure for
 reading a libxl migration v2 stream
Date: Mon, 13 Jul 2015 16:13:40 +0100
Message-ID: <55A3D5A4.2010204@citrix.com>
References: <1436788907-1921-1-git-send-email-andrew.cooper3@citrix.com>
	<1436788907-1921-18-git-send-email-andrew.cooper3@citrix.com>
	<21923.54363.294360.591599@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21923.54363.294360.591599@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 13/07/15 16:08, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH v3 17/28] tools/libxl: Infrastructure for reading a libxl migration v2 stream"):
> ...
>> +static void write_emulator_blob(libxl__egc *egc,
>> +                                libxl__stream_read_state *stream,
>> +                                libxl__sr_record_buf *rec)
> ...
>> +    libxl__carefd_begin();
>> +    writefd = open(path, O_WRONLY | O_CREAT | O_TRUNC, 0600);
>> +    if (writefd == -1) {
>> +        rc = ERROR_FAIL;
>> +        LOGE(ERROR, "unable to open %s", path);
>> +        libxl__carefd_unlock();
>> +        goto err;
>> +    }
> I have just spotted something else which I think both of us missed
> from my review of v2:
>
> I wrote:
>
>     If [you keep using carefd for this], then please use
>     libxl__carefd_opened.  (Best would be to libxl__carefd_opened to
>     save and restore errno and then you can call it unconditionally
>     after the open.)
>
> I meant `best would be to _change_ libxl__carefd_opened save and
> restore errno'.
>
>> +    assert(stream->emu_carefd == NULL);
>> +    stream->emu_carefd = libxl__carefd_opened(CTX, writefd);
> And then call it _unconditionally_, _immediately after_ the open.
>
> This means that the carefd functions bracketing open are easy to see
> and there is no entanglement with error-handling flow control.

libxl__carefd_opened() doesn't tolerate being handed -1.  It cannot be
used ahead of the error check.

I could see about introducing something like libxl__carefd_open() as a
carefd wrapper to open(2)

~Andrew