From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v3 19/28] tools/libxl: Convert a legacy
	stream if needed
Date: Mon, 13 Jul 2015 16:20:38 +0100
Message-ID: <55A3D746.5010309@citrix.com>
References: <1436788907-1921-1-git-send-email-andrew.cooper3@citrix.com>
	<1436788907-1921-20-git-send-email-andrew.cooper3@citrix.com>
	<21923.53345.222120.747892@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21923.53345.222120.747892@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 13/07/15 15:51, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH v3 19/28] tools/libxl: Convert a legacy stream if needed"):
>> For backwards compatibility, a legacy stream needs converting before
>> it can be read by the v2 stream logic.
>>
>> This causes the v2 stream logic to need to juggle two parallel tasks.
>> check_all_finished() is introduced for the purpose of joining the
>> tasks in both success and error cases.
> ...
>> +    /* If we started a conversion helper, we took ownership of its carefd. */
>> +    if (stream->chs.v2_carefd)
>> +        libxl__carefd_close(stream->chs.v2_carefd);
> This would be more obviously correct (or at least more obviously never
> leak a carefd) if you set v2_carefd to NULL here, and asserted its
> NULLness at the end of check_all_finished just before making the
> callback.

This argument applies to all the cleanup in this function, but we
already assert that stream_done() is strictly executed once.

It would seem wrong to me to check just v2_carefd here, given all the
other resources in need of cleanup.

>
> (I looked to see if you initialised it to NULL as well; you don't, but
> the existing code is not consistent about whether it works on systems
> where all-bits-0 is not NULL, and I think it unlikely that Xen would
> ever be made to work on such a system.)

Given how POSIX-dependent libxl is, I don't see this being likely either.

~Andrew