From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id BD6FEE00758; Mon, 13 Jul 2015 09:47:56 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.178 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 4EE4CE00474 for ; Mon, 13 Jul 2015 09:47:55 -0700 (PDT) Received: by wicmv11 with SMTP id mv11so67147936wic.1 for ; Mon, 13 Jul 2015 09:47:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=T3ZUDzjfaWbCcdDonJbTSamWWLqjOpOdJymbOB5F2Lo=; b=nIvYwV4LsZqaqD+V2tgjiAqc8Y/BjLoUk2HHP9NeWeOEO4aNURm5WSIhHrkorjKLu5 w4XekJ16mevoQkZdM3pZkvW4L3kG9PCLPE7CTGjBy3P+UFW4lAZ/XqghxO7QU8bcZq2K mqMr7TTI8o8DNnFOm2z6efdY5T9LhRDRFXJ298Q84rjzfiT9EOaevRxPSjJRW88s/vY0 KxLf6aGQ3I4x6gU5x+WSkwz9NH/okVI0Hi2BC3T+tZfpofM589GUN/30r3gDG4Q/FUz3 UMp/FXuhCk+F8ptIBI9V2Mx1T+ui3WCLQQEe5f2VaaLWzMSjp2A1mCruwWH/YI9FRhYE B5+A== X-Gm-Message-State: ALoCoQmn/GVwd3ugAHdPeWpiMV9Ug2+y+YilFXI9YZ/1RiUUBC2KIDr8HrdhWcnq2jXQYIASKRGI X-Received: by 10.180.97.129 with SMTP id ea1mr25398670wib.24.1436806074886; Mon, 13 Jul 2015 09:47:54 -0700 (PDT) Received: from [192.168.2.178] ([83.217.123.106]) by smtp.googlemail.com with ESMTPSA id c3sm30182081wja.3.2015.07.13.09.47.54 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jul 2015 09:47:54 -0700 (PDT) Message-ID: <55A3EBB9.5060109@intel.com> Date: Mon, 13 Jul 2015 17:47:53 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: toaster@yoctoproject.org References: <20150710144844.GA14439@linux.intel.com> In-Reply-To: <20150710144844.GA14439@linux.intel.com> Subject: Re: [review-request] ed/toaster/misc X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2015 16:47:56 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 10/07/15 15:48, Ed Bartosh wrote: > Hi reviewers, > > Please review fix for YOCTO: #7965: Wait for toaster gui to come > and couple of other changes: > 1. tiny refactoring change: get rid of _createdirpath function > 2. and small fix: Fix usage of wrong variables > > -- > Regards, > Ed * 7cee08d toaster: get rid of _createdirpath function * eae47f7 toaster: Fix usage of wrong variables * 321d6ae toaster: Wait for toaster gui to come Looks fine to me, though not familiar enough with build stuff to fully OK this branch. While you're in localhostbecontroller We could also get rid of def _shellcmd(self, command, cwd = None): if cwd is None: cwd = self.be.sourcedir #logger.debug("lbc_shellcmmd: (%s) %s" % (cwd, command)) p = subprocess.Popen(command, cwd = cwd, shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE) (out,err) = p.communicate() p.wait() if p.returncode: if len(err) == 0: err = "command: %s \n%s" % (command, out) else: err = "command: %s \n%s" % (command, err) #logger.warn("localhostbecontroller: shellcmd error %s" % err) raise ShellCmdException(err) else: #logger.debug("localhostbecontroller: shellcmd success") return out I believe with: subprocess.check_output Thanks, Michael