From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751999AbbGNFIr (ORCPT ); Tue, 14 Jul 2015 01:08:47 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:55495 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751241AbbGNFIq (ORCPT ); Tue, 14 Jul 2015 01:08:46 -0400 Message-ID: <55A4995C.4050701@wwwdotorg.org> Date: Mon, 13 Jul 2015 23:08:44 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Eric Anholt CC: linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , devicetree@vger.kernel.org, Thomas Gleixner , Jason Cooper Subject: Re: [PATCH 3/4] irqchip: Add documentation for the bcm2836 interrupt controller. References: <1436303617-17185-1-git-send-email-eric@anholt.net> <1436303617-17185-4-git-send-email-eric@anholt.net> <55A0A251.1010301@wwwdotorg.org> <87io9r9qsi.fsf@eliezer.anholt.net> In-Reply-To: <87io9r9qsi.fsf@eliezer.anholt.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/11/2015 12:01 AM, Eric Anholt wrote: > Stephen Warren writes: > >> On 07/07/2015 03:13 PM, Eric Anholt wrote: >>> This is a new per-cpu root interrupt controller on the >>> Raspberry Pi 2, which will chain to the bcm2835 interrupt >>> controller for peripheral interrupts. >> >>> diff --git >>> a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt >>> b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt >> >>> >>> +local_intc: local_intc { >> >>> + interrupt-parent = <&local_intc>; >> >> I think that property shouldn't be there? > > If you don't have it there, the core finds the interrupt-parent in > the parent node, and waits for that one before initializing (which > is in turn waiting for us). Note that for original 2835, you're > finding the parent node as well. Ah yes. It does indeed look like it's typical that the root IRQ controller points at itself. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 3/4] irqchip: Add documentation for the bcm2836 interrupt controller. Date: Mon, 13 Jul 2015 23:08:44 -0600 Message-ID: <55A4995C.4050701@wwwdotorg.org> References: <1436303617-17185-1-git-send-email-eric@anholt.net> <1436303617-17185-4-git-send-email-eric@anholt.net> <55A0A251.1010301@wwwdotorg.org> <87io9r9qsi.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87io9r9qsi.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eric Anholt Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lee Jones , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Gleixner , Jason Cooper List-Id: devicetree@vger.kernel.org On 07/11/2015 12:01 AM, Eric Anholt wrote: > Stephen Warren writes: > >> On 07/07/2015 03:13 PM, Eric Anholt wrote: >>> This is a new per-cpu root interrupt controller on the >>> Raspberry Pi 2, which will chain to the bcm2835 interrupt >>> controller for peripheral interrupts. >> >>> diff --git >>> a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt >>> b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt >> >>> >>> +local_intc: local_intc { >> >>> + interrupt-parent = <&local_intc>; >> >> I think that property shouldn't be there? > > If you don't have it there, the core finds the interrupt-parent in > the parent node, and waits for that one before initializing (which > is in turn waiting for us). Note that for original 2835, you're > finding the parent node as well. Ah yes. It does indeed look like it's typical that the root IRQ controller points at itself. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Mon, 13 Jul 2015 23:08:44 -0600 Subject: [PATCH 3/4] irqchip: Add documentation for the bcm2836 interrupt controller. In-Reply-To: <87io9r9qsi.fsf@eliezer.anholt.net> References: <1436303617-17185-1-git-send-email-eric@anholt.net> <1436303617-17185-4-git-send-email-eric@anholt.net> <55A0A251.1010301@wwwdotorg.org> <87io9r9qsi.fsf@eliezer.anholt.net> Message-ID: <55A4995C.4050701@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/11/2015 12:01 AM, Eric Anholt wrote: > Stephen Warren writes: > >> On 07/07/2015 03:13 PM, Eric Anholt wrote: >>> This is a new per-cpu root interrupt controller on the >>> Raspberry Pi 2, which will chain to the bcm2835 interrupt >>> controller for peripheral interrupts. >> >>> diff --git >>> a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt >>> b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt >> >>> >>> +local_intc: local_intc { >> >>> + interrupt-parent = <&local_intc>; >> >> I think that property shouldn't be there? > > If you don't have it there, the core finds the interrupt-parent in > the parent node, and waits for that one before initializing (which > is in turn waiting for us). Note that for original 2835, you're > finding the parent node as well. Ah yes. It does indeed look like it's typical that the root IRQ controller points at itself.