From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id BD33475D39 for ; Tue, 14 Jul 2015 06:02:09 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.15.1/8.15.1) with ESMTPS id t6E629IA000970 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 13 Jul 2015 23:02:09 -0700 (PDT) Received: from [128.224.162.227] (128.224.162.227) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.235.1; Mon, 13 Jul 2015 23:02:08 -0700 Message-ID: <55A4A5DD.3020101@windriver.com> Date: Tue, 14 Jul 2015 14:02:05 +0800 From: Zhixiong Chi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: "Burton, Ross" References: <1436257069-1908-1-git-send-email-zhixiong.chi@windriver.com> In-Reply-To: Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH][V2] db: add debug_lock option to show diagnostic info X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2015 06:02:10 -0000 Content-Type: multipart/alternative; boundary="------------030808020708000905030909" --------------030808020708000905030909 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Oh, I'm sorry for making a mistake, and it should be upstream-status: pending. On 2015年07月11日 06:29, Burton, Ross wrote: > > On 7 July 2015 at 09:17, Zhixiong Chi > wrote: > > +Index: db-6.0.30/dist/configure > > > Don't patch generated files as they'll change drastically over time > and make maintaining the patch impossible. > > Also if the patch has been submitted upstream, including a link to the > submission (bug, list thread, etc) is helpful when doing upgrades in > the future. > > Ross -- --------------------- Thanks, Zhixiong Chi Tel: +86-10-8477-7036 --------------030808020708000905030909 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit Oh, I'm sorry for making a mistake, and it should be upstream-status: pending.

On 2015年07月11日 06:29, Burton, Ross wrote:

On 7 July 2015 at 09:17, Zhixiong Chi <zhixiong.chi@windriver.com> wrote:
+Index: db-6.0.30/dist/configure

Don't patch generated files as they'll change drastically over time and make maintaining the patch impossible.

Also if the patch has been submitted upstream, including a link to the submission (bug, list thread, etc) is helpful when doing upgrades in the future.

Ross

-- 
---------------------
Thanks,
Zhixiong Chi
Tel: +86-10-8477-7036
--------------030808020708000905030909--