From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yang Hongyang Subject: Re: [PATCH v7 COLO 02/18] tools/libxl: handle colo_context records in a libxl migration v2 stream Date: Wed, 15 Jul 2015 08:34:52 +0800 Message-ID: <55A5AAAC.305@cn.fujitsu.com> References: <1435213872-10698-1-git-send-email-yanghy@cn.fujitsu.com> <1435213872-10698-3-git-send-email-yanghy@cn.fujitsu.com> <1436887162.25044.113.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1436887162.25044.113.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, Thanks for the review. On 07/14/2015 11:19 PM, Ian Campbell wrote: > On Thu, 2015-06-25 at 14:30 +0800, Yang Hongyang wrote: >> From: Wen Congyang >> >> Signed-off-by: Wen Congyang >> --- >> tools/libxl/libxl_internal.h | 3 +++ >> tools/libxl/libxl_stream_read.c | 51 +++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 54 insertions(+) > > This patch is certainly not so trivial that it can get away with a > subject only and no commit body. > > The same goes for patch #3. > > In particular both of them add some new stream state which is not > described anywhere. This patch is changed a lot due to the migration v2 change, I've added some commit message in v8, I will add more desciption as you suggested. > > Ian. > > . > -- Thanks, Yang.