From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 15 Jul 2015 09:19:55 +0200 Subject: [U-Boot] [PATCH 4/5] tools: mkimage: fix imximage header size In-Reply-To: <874a6782a666faec3520e1e9a58f7092@agner.ch> References: <1434716311-26189-1-git-send-email-albert.aribaud@3adev.fr> <1434716311-26189-2-git-send-email-albert.aribaud@3adev.fr> <1434716311-26189-3-git-send-email-albert.aribaud@3adev.fr> <1434716311-26189-4-git-send-email-albert.aribaud@3adev.fr> <1434716311-26189-5-git-send-email-albert.aribaud@3adev.fr> <559F7EC8.6020605@denx.de> <874a6782a666faec3520e1e9a58f7092@agner.ch> Message-ID: <55A6099B.6050908@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefan, On 14/07/2015 12:29, Stefan Agner wrote: >> >> Applied to u-boot-imx, thanks ! > > Sorry, just stumbled over this message now. > > We discussed exactly this issue already more than a year ago, see: > http://lists.denx.de/pipermail/u-boot/2014-April/177580.html I admit that I have forgotten it....thanks to revive it ! > > Back then you asked whether I asked Freescale about it. Earlier this > year I tried to get hold of that issue and asked Freescale on Community, > see: > https://community.freescale.com/thread/355161 > > However, no official confirmation or explanation so far. > > I think my patch back then solves the issue nicer. The struct dcd_v2_t > is not the reason the whole header is not aligned by 8-byte, it is a > problem of the boot_data_t header which is 12 bytes long. So inserting > the padding just after struct boot_data_t (or inside of struct > boot_data_t) seems to be more appropriate. I see. Albert, can you test on your board if Stefan's patch solves your issue, too ? I could then revert this one and apply Stefan's. It remains doubious how the ROMs on Freescale are interpretating the header, but we can only test it. Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================